Skip to content

Commit 3283ef7

Browse files
committed
Doxygen version.
Use LED_BUILTIN instead of FEEDBACK_LED FeedbackLEDPin is 0. Use F_CPU instead of SYSCLOCK. Remove IRBoardDefs.h and outdated readmdFrench.md.
1 parent e8e8e10 commit 3283ef7

23 files changed

+417
-423
lines changed

.github/issue_template.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ Please delete all unchecked lines above :-)
4949

5050
### Pin(s) used for IR-receive, if not default
5151

52+
[Use code blocks](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#code); **it helps us help you when we can read your code!**
53+
Please also refrain from pasting more than 50 lines of code in a post, instead **[create a gist](https://gist.github.com/) if you need to share large snippets**
5254
**Code Block:**
5355
```
5456
@@ -58,7 +60,6 @@ Please delete all unchecked lines above :-)
5860
5961
```
6062

61-
Use [a gist](gist.github.com) if the code exceeds 30 lines
6263

6364
### Current behavior
6465
<!-- Paste the code or repository link, if applicable. -->

Contributing.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# Contribution Guidelines
22

3-
This library is the culmination of the expertise of many members of the open source community who have dedicated their time and hard work. The best way to ask for help or propose a new idea is to [create a new issue](https://github.com/z3t0/Arduino-IRremote/issues/new) while creating a Pull Request with your code changes allows you to share your own innovations with the rest of the community.
3+
This library is the culmination of the expertise of many members of the open source community who have dedicated their time and hard work.
4+
The best way to ask for help or propose a new idea is to create a new discussion and / or a new Pull Request
5+
with your code changes to allow you to share your own innovations with the rest of the community.
46

5-
The following are some guidelines to observe when creating issues or PRs:
6-
- Be friendly; it is important that we can all enjoy a safe space as we are all working on the same project and it is okay for people to have different ideas
7-
- [Use code blocks](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#code); **it helps us help you when we can read your code!** On that note also refrain from pasting more than 30 lines of code in a post, instead **[create a gist](https://gist.github.com/) if you need to share large snippets**
8-
- Use reasonable titles; refrain from using overly long or capitalized titles as they are usually annoying and do little to encourage others to help :smile:
9-
- Be detailed; refrain from mentioning code problems without sharing your source code and always give information regarding your board and version of the library
10-
- Use the style; we use the original [C Style by Kerninghan / Ritchie](https://en.wikipedia.org/wiki/Indentation_style#K&R_style) in [variant: 1TBS (OTBS)](https://en.wikipedia.org/wiki/Indentation_style#Variant:_1TBS_(OTBS)). In short: 4 spaces indentation, no tabs, opening braces on the same line, braces are mandatory on all if/while/do, no hard line length limit. To beautify your code, you may use the online formatter [here](https://www.freecodeformat.com/c-format.php).
11-
- Choose the right Pull Request target; if you only have **minor changes or adding a new protocol**, choose **master** as target for your Pull Request. If have a change **addressing more general aspects** of this library or think, that the PR should be **discussed and reviewed**, choose the **dev** branch as target for your Pull Request like described [here](https://guides.github.com/introduction/flow/).
12-
13-
If there is any need to contact me then you can find my email on the README, I do not mind responding to emails but it would be in your own interests to create issues if you need help with the library as responses would be from a larger community with greater knowledge!
7+
The following are some guidelines to observe when creating discussions / PRs:
8+
- Be friendly; it is important that we can all enjoy a safe space as we are all working on the same project and **it is okay for people to have different ideas**.
9+
- Use reasonable titles; refrain from using overly long or capitalized titles as they are usually annoying and do little to encourage others to help :smile:.
10+
- Use the style; we use the original [C Style by Kerninghan / Ritchie](https://en.wikipedia.org/wiki/Indentation_style#K&R_style) in [variant: 1TBS (OTBS)](https://en.wikipedia.org/wiki/Indentation_style#Variant:_1TBS_(OTBS)).
11+
In short: 4 spaces indentation, no tabs, opening braces on the same line, braces are mandatory on all if/while/do, no hard line length limit.
12+
To beautify your code, you may use the online formatter [here](https://www.freecodeformat.com/c-format.php).
13+
- Cover **all** occurences of the problem / addition you address with your PR. Do not forget the documentation like it is done for existing code. Code changes without proper documentation will be rejected!

Doxyfile

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ PROJECT_LOGO =
5858
# entered, it will be relative to the location where doxygen was started. If
5959
# left blank the current directory will be used.
6060

61-
OUTPUT_DIRECTORY =
61+
OUTPUT_DIRECTORY = ..\Arduino-IRremote_gh-pages
6262

6363
# If the CREATE_SUBDIRS tag is set to YES then doxygen will create 4096 sub-
6464
# directories (in 2 levels) under the output directory of each output format and
@@ -815,7 +815,6 @@ WARN_LOGFILE =
815815

816816
INPUT = src \
817817
src/private \
818-
examples/MicroGirs \
819818
.
820819

821820
# This tag can be used to specify the character encoding of the source files
@@ -1064,7 +1063,7 @@ VERBATIM_HEADERS = YES
10641063
# classes, structs, unions or interfaces.
10651064
# The default value is: YES.
10661065

1067-
ALPHABETICAL_INDEX = YES
1066+
ALPHABETICAL_INDEX = NO
10681067

10691068
# The COLS_IN_ALPHA_INDEX tag can be used to specify the number of columns in
10701069
# which the alphabetical index list will be split.
@@ -1096,8 +1095,6 @@ GENERATE_HTML = YES
10961095
# The default directory is: html.
10971096
# This tag requires that the tag GENERATE_HTML is set to YES.
10981097

1099-
# This name is selected to be able to easily publish with GitHub's gh-pages.
1100-
11011098
HTML_OUTPUT = docs
11021099

11031100
# The HTML_FILE_EXTENSION tag can be used to specify the file extension for each
@@ -1457,7 +1454,7 @@ DISABLE_INDEX = NO
14571454
# The default value is: NO.
14581455
# This tag requires that the tag GENERATE_HTML is set to YES.
14591456

1460-
GENERATE_TREEVIEW = NO
1457+
GENERATE_TREEVIEW = YES
14611458

14621459
# The ENUM_VALUES_PER_LINE tag can be used to set the number of enum values that
14631460
# doxygen will group on one line in the generated HTML documentation.

README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ Available as Arduino library "IRremote"
1111

1212
This library enables you to send and receive using infra-red signals on an Arduino.
1313

14-
Tutorials and more information will be made available on [the official homepage](https://arduino-irremote.github.io/Arduino-IRremote/).
14+
# API
15+
A Doxygen documentation of the sources is available on [project homepage](https://arduino-irremote.github.io/Arduino-IRremote/).
1516

1617
# Installation
1718
Click on the LibraryManager badge above to see the [instructions](https://www.ardu-badge.com/IRremote/zip).
@@ -122,10 +123,10 @@ Modify it by commenting them out or in, or change the values if applicable. Or d
122123
| `FEEDBACK_LED_IS_ACTIVE_LOW` | Before `#include <IRremote.h>` | disabled | Required on some boards (like my BluePill and my ESP8266 board), where the feedback LED is active low. |
123124
| `DISABLE_LED_FEEDBACK_FOR_RECEIVE` | Before `#include <IRremote.h>` | disabled | This disables the LED feedback code for receive, thus saving around 108 bytes program space and halving the receiver ISR processing time. |
124125
| `IR_INPUT_IS_ACTIVE_HIGH` | Before `#include <IRremote.h>` | disabled | Enable it if you use a RF receiver, which has an active HIGH output signal. |
125-
| `RAW_BUFFER_LENGTH` | IRremoteint.h | 101 | Buffer size of raw input buffer. Must be odd! |
126+
| `RAW_BUFFER_LENGTH` | IRremoteInt.h | 101 | Buffer size of raw input buffer. Must be odd! |
126127
| `DEBUG` | IRremoteInt.h | disabled | Enables lots of lovely debug output. |
127-
| `IR_SEND_DUTY_CYCLE` | IRremoteint.h | 30 | Duty cycle of IR send signal. |
128-
| `MICROS_PER_TICK` | IRremoteint.h | 50 | Resolution of the raw input buffer data. |
128+
| `IR_SEND_DUTY_CYCLE` | IRremoteInt.h | 30 | Duty cycle of IR send signal. |
129+
| `MICROS_PER_TICK` | IRremoteInt.h | 50 | Resolution of the raw input buffer data. |
129130
|-|-|-|-|
130131
| `IR_INPUT_PIN` | TinyIRReceiver.h | 2 | The pin number for TinyIRReceiver IR input, which gets compiled in. |
131132
| `IR_FEEDBACK_LED_PIN` | TinyIRReceiver.h | `LED_BUILTIN` | The pin number for TinyIRReceiver feedback LED, which gets compiled in. |
@@ -143,7 +144,7 @@ If you are using Sloeber as your IDE, you can easily define global symbols with
143144

144145
# Supported Boards
145146
- Arduino Uno / Mega / Leonardo / Duemilanove / Diecimila / LilyPad / Mini / Fio / Nano etc.
146-
- Teensy 1.0 / 1.0++ / 2.0 / 2++ / 3.0 / 3.1 / Teensy-LC; Credits: @PaulStoffregen (Teensy Team)
147+
- Teensy 1.0 / 1.0++ / 2.0 / 2++ / 3.0 / 3.1 / Teensy-LC; Credits: PaulStoffregen (Teensy Team)
147148
- Sanguino
148149
- ATmega8, 48, 88, 168, 328
149150
- ATmega8535, 16, 32, 164, 324, 644, 1284,
@@ -221,13 +222,11 @@ See [API reference in wiki](https://github.com/Arduino-IRremote/Arduino-IRremote
221222

222223
To generate the API documentation,
223224
Doxygen, as well as [Graphviz](http://www.graphviz.org/) should be installed.
224-
(Note that on Windows, it may be necessary to add the Graphviz binary directory
225-
(something like `C:\Program Files\Graphviz2.38\bin`)
226-
to the `PATH` variable manually.)
225+
(Note that on Windows, it is useful to specify the installer to add Graphviz to PATH or to do it manually.
227226
With Doxygen and Graphviz installed, issue the command
228227
`doxygen` from the command line in the main project directory, which will
229228
generate the API documentation in HTML format.
230-
The just generated `api-doc/index.html` can now be opened in a browser.
229+
The just generated `docs/index.html` can now be opened in a browser.
231230

232231
## Why do we use 33% duty cycle
233232
We do it according to the statement in the [Vishay datasheet](https://www.vishay.com/docs/80069/circuit.pdf):

changelog.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
# Changelog
2+
The latest version may not be released!
3+
14
## 3.1.0
2-
- Replaced #define DECODE_NEC 1/0 by defining/not defining.
5+
- Replaced `#define DECODE_NEC 1/0` by defining/not defining.
36
- USE_SOFT_SEND_PWM is active by default.
47
- Refactored Board specific code.
58
- Separated timer and feedback LED related code.
@@ -12,6 +15,8 @@
1215
- Added unit test and fixed LG send bug.
1316
- MATCH_MARK() etc. now available as matchMark().
1417
- Added ATtiny88 support.
18+
- Use LED_BUILTIN instead of FEEDBACK_LED FeedbackLEDPin is 0.
19+
- Use F_CPU instead of SYSCLOCK.
1520

1621
## 3.0.2
1722
- Bug fix for USE_OLD_DECODE.
@@ -80,7 +85,7 @@
8085
- NEC repeat implementation.
8186
- Formatting and changing `TIMER_CONFIG_KHZ` and `TIMER_CONFIG_NORMAL` macros to static functions.
8287
- Added `IRAM_ATTR` for ESP32 ISR.
83-
- Removed #define `HAS_AVR_INTERRUPT_H`.
88+
- Removed `#define HAS_AVR_INTERRUPT_H`.
8489
- Changed Receiver States. Now starting with 0.
8590
- Changed switch to if / else if in IRRemote.cpp because of ESP32 compiler bug.
8691
- Changed `DEBUG` handling since compiler warns about empty "IF" or "ELSE" statements in IRRemote.cpp.
@@ -99,7 +104,7 @@
99104
Changes from #283 by bengtmartensson
100105
- Added function sendRaw_P() for sending data from flash.
101106
Changes from #268 by adamlhumphreys
102-
- Optimized by reducing floating point operations as suggested by @madmalkav (#193).
107+
- Optimized by reducing floating point operations as suggested by madmalkav (#193).
103108
- Optimized with macros when using default `MICROS_PER_TICK` and `TOLERANCE`.
104109
- Made decodeHash as a settable protocol defined by `DECODE_HASH`.
105110
- Added Philips Extended RC-5 protocol support [PR #522] (https://github.com/Arduino-IRremote/Arduino-IRremote/pull/522)
@@ -165,7 +170,7 @@ Changes from #268 by adamlhumphreys
165170
- Fixed and Improved many coding errors
166171
- Fixed Aiwa RC-T501 Decoding
167172
- Fixed Interrupt on ATmega8
168-
- Switched to Stable Release of @PlatformIO
173+
- Switched to Stable Release of PlatformIO
169174

170175
### Additions
171176
- Added Aiwa RC-T501 Protocol

examples/IRremoteInfo/IRremoteInfo.ino

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ void dumpTimerPin() {
105105

106106
void dumpClock() {
107107
Serial.print(F("MCU Clock: "));
108-
Serial.println(SYSCLOCK);
108+
Serial.println(F_CPU);
109109
}
110110

111111
void dumpPlatform() {

readmdFrench.md

Lines changed: 0 additions & 97 deletions
This file was deleted.

0 commit comments

Comments
 (0)