Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove auto globals install #7009

Merged
merged 7 commits into from
Aug 2, 2023
Merged

feat!: remove auto globals install #7009

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
860f42d
feat!: remove auto globals install
jacob-ebey Jul 31, 2023
8ba9106
install globals in remix-serve
jacob-ebey Aug 1, 2023
12565a1
install globals in integration fixture env
jacob-ebey Aug 1, 2023
9e91120
Merge branch 'dev' into v2-remove-auto-globals-install
jacob-ebey Aug 1, 2023
26e60af
ignore
jacob-ebey Aug 2, 2023
b1861cf
Merge branch 'dev' of https://github.com/remix-run/remix into v2-remo…
jacob-ebey Aug 2, 2023
e214b51
install globals in HMR tests
jacob-ebey Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ignore
  • Loading branch information
@jacob-ebey
jacob-ebey committed Aug 2, 2023
commit 26e60afe5317ccc0de35b6fb960a1c994e93ca9d
4 changes: 4 additions & 0 deletions integration/helpers/create-fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,13 @@ import type { JsonObject } from "type-fest";
import type { AppConfig } from "@remix-run/dev";
import { ServerMode } from "@remix-run/server-runtime/mode";

// @ts-ignore
import type { ServerBuild } from "../../build/node_modules/@remix-run/server-runtime";
// @ts-ignore
import { createRequestHandler } from "../../build/node_modules/@remix-run/server-runtime";
// @ts-ignore
import { createRequestHandler as createExpressHandler } from "../../build/node_modules/@remix-run/express";
// @ts-ignore
import { installGlobals } from "../../build/node_modules/@remix-run/node";

const TMP_DIR = path.join(process.cwd(), ".tmp", "integration");
Expand Down