Skip to content

Commit 66adc8f

Browse files
authored
fix(vite): fix errors for non-existent index.html importer (#8353)
1 parent 6adaee8 commit 66adc8f

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

.changeset/curly-coats-reflect.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@remix-run/dev": patch
3+
---
4+
5+
Vite: Fix errors for non-existent `index.html` importer
6+

packages/remix-dev/vite/plugin.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,13 @@ export const remixVitePlugin: RemixVitePlugin = (options = {}) => {
947947
serverFileRE.test(resolved!.id) || serverDirRE.test(resolved!.id);
948948
if (!isDotServer) return;
949949

950-
if (!importer) throw Error(`Importer not found: ${id}`);
950+
if (!importer) return;
951+
if (viteCommand !== "build" && importer.endsWith(".html")) {
952+
// Vite has a special `index.html` importer for `resolveId` within `transformRequest`
953+
// https://github.com/vitejs/vite/blob/5684fcd8d27110d098b3e1c19d851f44251588f1/packages/vite/src/node/server/transformRequest.ts#L158
954+
// https://github.com/vitejs/vite/blob/5684fcd8d27110d098b3e1c19d851f44251588f1/packages/vite/src/node/server/pluginContainer.ts#L668
955+
return;
956+
}
951957

952958
let vite = importViteEsmSync();
953959
let pluginConfig = await resolvePluginConfig();

0 commit comments

Comments
 (0)