-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
perf: use replaceAll
for slash normalisation
#13738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @43081j, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
334a27c
to
b835903
Compare
🦋 Changeset detectedLatest commit: 59f5225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Splitting and joining is slow and results in garbage collection each time. We can instead use a string `replaceAll` for a small perf gain.
b835903
to
59f5225
Compare
replaceAll
for slash normalisation
@Hardanish-Singh Would you mind refraining from adding approvals to PRs? It's adding noise to the PR history. Thanks! I think we've got enough committer approvals, so let's merge this in. Thanks! |
Splitting and joining is slow and results in garbage collection each time. We can instead use a string
replaceAll
for a small perf gain.