Skip to content

perf: use replaceAll for slash normalisation #13738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

43081j
Copy link

@43081j 43081j commented Jun 4, 2025

Splitting and joining is slow and results in garbage collection each time. We can instead use a string replaceAll for a small perf gain.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 4, 2025

Hi @43081j,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@43081j 43081j force-pushed the perf-slash-replace branch from 334a27c to b835903 Compare June 4, 2025 09:36
Copy link

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: 59f5225

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/remix-routes-option-adapter Patch
@react-router/fs-routes Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 4, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Splitting and joining is slow and results in garbage collection each
time. We can instead use a string `replaceAll` for a small perf gain.
@43081j 43081j force-pushed the perf-slash-replace branch from b835903 to 59f5225 Compare June 4, 2025 09:37
@MichaelDeBoey MichaelDeBoey changed the title perf: use replaceAll for slash normalisation perf: use replaceAll for slash normalisation Jun 4, 2025
@timdorr
Copy link
Member

timdorr commented Jun 4, 2025

@Hardanish-Singh Would you mind refraining from adding approvals to PRs? It's adding noise to the PR history. Thanks!

I think we've got enough committer approvals, so let's merge this in. Thanks!

@timdorr timdorr merged commit c7db95a into remix-run:dev Jun 4, 2025
5 checks passed
@43081j 43081j deleted the perf-slash-replace branch June 4, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants