Skip to content

refactor: use native Node.js instead of fs-extra #13736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

refactor: use native Node.js instead of fs-extra #13736

merged 1 commit into from
Jun 5, 2025

Conversation

MichaelDeBoey
Copy link
Member

I'm sure people from the wider @e18e ecosystem cleanup (like @43081j & @outslept) will be very happy to see these kind of changes as well

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7b81e56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 4, 2025
Open
@MichaelDeBoey MichaelDeBoey force-pushed the remove-fs-extra-usage branch from f58301d to 6d7ce02 Compare June 4, 2025 01:51
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 4, 2025
Open
43081j
43081j reviewed Jun 4, 2025
View reviewed changes
43081j
43081j reviewed Jun 4, 2025
View reviewed changes
@MichaelDeBoey MichaelDeBoey force-pushed the remove-fs-extra-usage branch from 6d7ce02 to 960492e Compare June 4, 2025 11:51
@MichaelDeBoey MichaelDeBoey requested a review from 43081j June 4, 2025 14:39
43081j
43081j approved these changes Jun 4, 2025
View reviewed changes
Copy link

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

CI failure seems unrelated

@MichaelDeBoey
Copy link
Member Author

@43081j Afk right now, but I do think it's related somehow: https://github.com/remix-run/react-router/actions/runs/15441530739/job/43460267799?pr=13736#step:8:306

43081j
43081j reviewed Jun 4, 2025
View reviewed changes
@MichaelDeBoey MichaelDeBoey force-pushed the remove-fs-extra-usage branch from 960492e to 3a54259 Compare June 4, 2025 16:01
@MichaelDeBoey MichaelDeBoey requested a review from 43081j June 4, 2025 22:01
@MichaelDeBoey MichaelDeBoey force-pushed the remove-fs-extra-usage branch 2 times, most recently from 110da80 to c459ed0 Compare June 5, 2025 14:39
@MichaelDeBoey MichaelDeBoey force-pushed the remove-fs-extra-usage branch from c459ed0 to 7b81e56 Compare June 5, 2025 20:00
@timdorr
Copy link
Member

timdorr commented Jun 5, 2025

Looks great. Let's merge it in!

@timdorr timdorr merged commit 536af57 into remix-run:dev Jun 5, 2025
8 checks passed
@MichaelDeBoey MichaelDeBoey deleted the remove-fs-extra-usage branch June 5, 2025 22:51
@timdorr timdorr mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdorr timdorr timdorr approved these changes

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

@43081j 43081j Awaiting requested review from 43081j

Assignees
No one assigned
Labels
CLA Signed dependencies Pull requests that update a dependency file pkg:create-react-router pkg:@react-router/dev pkg:@react-router/fs-routes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @timdorr @43081j