fix(dev): improve server build asset handling #13547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently log a message during the build when moving assets from the server build to the client, but we weren't logging anything when cleaning server assets that already exist in the client build. This led to some confusion because Vite logs that these files were generated, but after the build has finished the assets are no longer there.
To avoid this confusion, we now log whenever assets are handled in any way, not just when they're moved.
While working on this, I also realised that we don't honour the consumer's
build.ssrEmitAssets
option if they explicitly want to keep these assets, so the logic and logging has also been updated to account for this.Before:

After:
