Fix custom SSR build input with serverBundles
#13107
Conversation
🦋 Changeset detectedLatest commit: 7fea63d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "bundle-a._index.tsx", | ||
| "bundle-a.route-a.tsx", | ||
| "bundle-a.route-b.tsx", | ||
| "bundle_a.tsx", |
There was a problem hiding this comment.
As noted in the changeset, we needed to replace hyphens with underscores in our server bundle IDs since we're also testing against the Vite Environment API. This is technically a breaking change but unlikely to break anyone in practice, and only those who have opted into an unstable API.
There was a problem hiding this comment.
Is this something the Vercel preset will need to do as well? i.e. currently it generates a bundle ID such as nodejs-eyJydW50aW1lIjoibm9kZWpzIn0. Does that need to be nodejs_eyJydW50aW1lIjoibm9kZWpzIn0 instead?
There was a problem hiding this comment.
Ah nice catch, I didn't realise this. Yep, swapping for an underscore now is a good idea.
| input: | ||
| (ctx.reactRouterConfig.future.unstable_viteEnvironmentApi | ||
| ? viteUserConfig.environments?.ssr?.build?.rollupOptions?.input | ||
| : viteUserConfig.build?.rollupOptions?.input) ?? | ||
| virtual.serverBuild.id, |
There was a problem hiding this comment.
Since the route-ids query string is no longer used, this config is now common across all SSR builds including server bundles.
| @@ -184,15 +183,18 @@ async function viteBuild( | |||
| optimizeDeps: { force }, | |||
| clearScreen, | |||
| logLevel, | |||
| ...{ __reactRouterEnvironmentBuildContext: environmentBuildContext }, | |||
| ...{ | |||
| __reactRouterPluginContext: ctx, | |||
There was a problem hiding this comment.
We now pass the resolved plugin context object into each build so we can re-use the build manifest rather than re-evaluating the serverBundles function whenever our Vite plugin is instantiated.
markdalgleish
deleted the
markdalgleish/server-bundles-custom-ssr-build-input
branch
…ith Vite Environments API (#13101) See this upcoming change in React Router: remix-run/react-router#13107 From the changeset: > Note that for consumers using the `future.unstable_viteEnvironmentApi` and `serverBundles` options together, hyphens are no longer supported in server bundle IDs since they also need to be valid Vite environment names.
…d-route-typegen * upstream/dev: (65 commits) Generate types for `virtual:react-router/server-build` (remix-run#13152) Add support for client context and middleware (unstable) (remix-run#12941) Add playground for `vite-plugin-cloudflare` (remix-run#13151) do not typegen params for layout routes with a corresponding index (remix-run#13131) (remix-run#13140) Fix types for `loaderData` and `actionData` that contain `Record`s (remix-run#13139) chore: format chore(dev): remove unused dependencies (remix-run#13134) Remove unused Vite file system watcher (remix-run#13133) Remove stale changesets cherry-picked into release-next for 7.2.0 Fix custom SSR build input with `serverBundles` (remix-run#13107) Skip resource route flow in dev mode when SPA mode is enabled (remix-run#13113) chore: format Add integration test for `vite-plugin-cloudflare` (remix-run#13099) Fix custom client `build.rollupOptions.output.entryFileNames` (remix-run#13098) Detect lazy route discovery manifest version mismatches and trigger reloads (remix-run#13061) Fix critical CSS with custom `Vite.DevEnvironment` (remix-run#13066) Fix usage of `prerender` option with `serverBundles` (remix-run#13082) Fix support for custom `build.assetsDir` (remix-run#13077) Add changeset for remix-run#13064 Only import the root route when SSRing SPA mode's index.html (remix-run#13023) ...
|
🤖 Hello there, We just published version Thanks! |
Fixes #13104.
This fixes two issues:
build.rollupOptions.inputvalue was provided in the SSR build, this was not honoured whenserverBundleswere configured. This PR ensures that all SSR builds honour this value.virtual:react-router/server-build, this fails to account for the query string used to supportserverBundles(e.g.virtual:react-router/server-build?route-ids=foo,bar,baz. This PR alters the logic for getting the route IDs of a server bundle build so they're no longer encoded in the query string. Instead, the server bundle ID is extracted from the environment name, and this is then used to look up its routes in the React Router build manifest.