Warning: You cannot PUSH the same path using hash history

[impguard]

This is very similar to #2431, where I'm getting this warning.

Luckily, remix-run/history#43 seems to fix it in the general case, but I'm getting this warning in a very specific instance.

With a basic application with:

    <Router history={hashHistory}>
        <Route path='/' component={App}>
            <IndexRoute component={GettingStarted} />
            <Route path="reports" component={Reports} />
            <Route path="templates" component={Templates} />
        </Route>
    </Router>

The first time I load the application at http://domain-name/#/ and click on a Link to '/', I get this error. Afterwards, I never see it again.

Is this intended or did I set something up incorrectly?

[ryanflorence]

Seems like a weird warning. You can't really tell the user not to click links, and it'd be really cumbersome to make the link not link to anywhere when its active. Unless @mjackson has some reason I'm unaware of, we'd happily merge a PR that removes the warning and ship a release.

[mjackson]

The warning is there just to let you know that when you're using hash history, you can't actually PUSH the same path; the browser won't add anything to the history stack.

But you should only get this warning in development. If you generate your production build correctly (using NODE_ENV=production) you shouldn't see this warning in production.

[ryanflorence]

Can we just leave that to docs and not a warning?

[sloansparger]

If the warning stays, having a console.warn would be helpful. I thought I was doing something wrong, but this isn't really an error.

[eko24ive]

@mjackson any plans on changing it ?

[benwiley4000]

@ryanflorence @mjackson I'm pretty convinced this warning should go - even if it is development only, it adds a ton of noise for developers who want to distill down to real errors, and in some cases it's an annoying implementation hoop to jump through in order to avoid a redundant push. Since the history library is set up to ignore redundant pushes there's not really a need to issue a warning. If you ask me. 🙂

[timdorr]

It really should stay. It's very easy to miss that you're trying to push the same path and makes it hard to track down the error. Clicking something and nothing happening is a terrible and frustrating DX because there is nothing to trace.

[benwiley4000]

^ fair point I hadn't considered.

[arjunmehta]

I agree with @sloansparger, If it's a warning (which it says it is), then it should use console.warn(), not console.error()

[robcalcroft]

An error gives the message this will break the app, which it will not necessarily. The message is for debugging purposes.