You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When importing generated types for a route, import type { Route } from "./+types/route";, there is no analog to ShouldRevalidateFunctionArgs in Route.
Because there are two sets of route params, currentParams and nextParams in ShouldRevalidateFunctionArgs it seems like an good candidate type to generate.
So that's what this request is, to add the Route.ShouldRevalidateArgs and Route.ShouldRevalidateFunction types to the generated code when react-router typegen is ran.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
When importing generated types for a route,
import type { Route } from "./+types/route";
, there is no analog toShouldRevalidateFunctionArgs
inRoute
.Because there are two sets of route params,
currentParams
andnextParams
inShouldRevalidateFunctionArgs
it seems like an good candidate type to generate.So that's what this request is, to add the
Route.ShouldRevalidateArgs
andRoute.ShouldRevalidateFunction
types to the generated code whenreact-router typegen
is ran.Beta Was this translation helpful? Give feedback.
All reactions