Revert "Debug failing test"

This reverts commit 0065a74.

Author: brophdawg11

integration/middleware-test.ts

@@ -397,7 +397,7 @@ test.describe("Middleware", () => {
       appFixture.close();
     });
 
-    test.only("calls clientMiddleware for routes even without a loader", async ({
+    test("calls clientMiddleware for routes even without a loader", async ({
       page,
     }) => {
       let fixture = await createFixture({
@@ -416,22 +416,18 @@ test.describe("Middleware", () => {
             });
           `,
           "app/routes/_index.tsx": js`
-            import { Link, useNavigation } from 'react-router'
+            import { Link } from 'react-router'
             export default function Component({ loaderData }) {
-              return <Link to="/a/b/c">Link ({useNavigation().state})</Link>;
+              return <Link to="/a/b/c">Link</Link>;
             }
           `,
           "app/routes/a.tsx": js`
             import { Outlet } from 'react-router'
             export const unstable_clientMiddleware = [
-              ({ context }) => {
-                console.log('a client middleware')
-                context.a = true;
-              },
+              ({ context }) => { context.a = true; },
             ];
 
             export function clientLoader({ context }) {
-              console.log('a client loader')
               return JSON.stringify(context)
             }
 
@@ -463,19 +459,9 @@ test.describe("Middleware", () => {
 
       let appFixture = await createAppFixture(fixture);
 
-      page.on("console", (msg) => {
-        console.log("console:", msg.text());
-      });
-
-      page.on("request", (req) => {
-        console.log("req:", req.url());
-      });
-
       let app = new PlaywrightFixture(appFixture, page);
       await app.goto("/", true);
       (await page.$('a[href="/a/b/c"]'))?.click();
-      await new Promise((r) => setTimeout(r, 1000));
-      console.log(await app.getHtml());
       await page.waitForSelector("h4");
       expect(await page.innerText("h2")).toBe('A: {"a":true,"b":true}');
       expect(await page.innerText("h3")).toBe("B");

integration/playwright.config.ts

@@ -21,7 +21,7 @@ const config: PlaywrightTestConfig = {
     /* Maximum time expect() should wait for the condition to be met. */
     timeout: 5_000,
   },
-  //forbidOnly: !!process.env.CI,
+  forbidOnly: !!process.env.CI,
   retries: process.env.CI ? 3 : 0,
   reporter: process.env.CI ? "dot" : [["html", { open: "never" }]],
   use: { actionTimeout: 0 },
@@ -31,23 +31,23 @@ const config: PlaywrightTestConfig = {
       name: "chromium",
       use: devices["Desktop Chrome"],
     },
-    // {
-    //   name: "webkit",
-    //   use: devices["Desktop Safari"],
-    // },
-    // {
-    //   name: "msedge",
-    //   use: {
-    //     ...devices["Desktop Edge"],
-    //     // Desktop Edge uses chromium by default
-    //     // https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/deviceDescriptorsSource.json#L1502
-    //     channel: "msedge",
-    //   },
-    // },
-    // {
-    //   name: "firefox",
-    //   use: devices["Desktop Firefox"],
-    // },
+    {
+      name: "webkit",
+      use: devices["Desktop Safari"],
+    },
+    {
+      name: "msedge",
+      use: {
+        ...devices["Desktop Edge"],
+        // Desktop Edge uses chromium by default
+        // https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/deviceDescriptorsSource.json#L1502
+        channel: "msedge",
+      },
+    },
+    {
+      name: "firefox",
+      use: devices["Desktop Firefox"],
+    },
   ],
 };
 

package.json

@@ -20,7 +20,7 @@
     "test:integration:run": "pnpm playwright:integration",
     "test:integration": "pnpm build && pnpm test:integration:run",
     "posttest:integration:run": "pnpm clean:integration",
-    "playwright:integration": "playwright test --config ./integration/playwright.config.ts middleware",
+    "playwright:integration": "playwright test --config ./integration/playwright.config.ts",
     "vite-ecosystem-ci:build": "pnpm build",
     "vite-ecosystem-ci:before-test": "pnpm playwright install",
     "vite-ecosystem-ci:test": "pnpm playwright:integration --project=chromium && pnpm clean:integration",