Broken Stringify a list item

[artalar]

Subject of the issue

Broken Stringify a list item

Your environment

• windows 7
• Names and version of required packages
• remark@9.0.0, remark-stringify@5.0.0

Steps to reproduce

if (node.type === 'list') node.children.map(remark().stringify)

https://codesandbox.io/s/81kw44yowj

Expected behaviour

return array of strings

Actual behaviour

TypeError: Cannot read property 'length' of undefined

this listItem call paste not enough arguments

[wooorm]

@artalar What output would you expect? How does one list-item look?

Also, why not:

if (node.type === 'list') remark().stringify(node)

[artalar]

@wooorm i was attaching the link to reproduce (https://codesandbox.io/s/81kw44yowj)

const remark = require("remark");

const nodes = remark().parse(
  `
- 1
- 2
`
);

// expected `result` to be  `['1', '2']`
// currently `TypeError: Cannot read property 'length' of undefined`
const result = nodes.children[0].children.map(remark().stringify);

Also, why not:

Becouse i need to separete every list item text

[wooorm]

Well, the list holds information on how to compile the list-items, e.g., which bullet to use.
How could we create bullets if we don’t have this information 🤔

[artalar]

@wooorm [how I supose] list-item value doesn't know about list context and doesn't need a bullet, because a bullet - is the attribute of a list-item, not of its value.

[wooorm]

Well, currently it does, and it’ll be a breaking change to change it:

because a bullet is the attribute of a list-item, not of its value.

Yes, and that’s how it works now? 🤔

[artalar]

@wooorm I don't get it. So why I have the error?

How I can get string (raw) value of list-item? Can u fork codesandbox example and attach a link to fixed version?

[wooorm]

You get the error because this function is called, but there’s no parent context, so it doesn’t know how to create bullets.

How I can get string (raw) value of list-item?

By passing the contents of a list-item to stringify.

[artalar]

@wooorm how can I passing the contents of a list-item to stringify? Can you add the code snippet?

[wooorm]

say node was a listItem, you can pass the contents with a node.children.map(stringify).
Also note that #364 is fixing this.

[artalar]

@wooorm get it, thanks, it works!

But with blockquote i have got new issue =\

(https://codesandbox.io/s/81kw44yowj)

[wooorm]

@artalar that’s really weird and shouldn’t happen. Could you investigate more in depth 🤔

[artalar]

Sure, but tommorow or later

[artalar]

@wooorm I was debugging it. maps second callback argument is an index - number - it is not a valid argument for stringify.

node.children.map(el => stringify(el)) works fine

[wooorm]

Perfect!