Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ref in types #668

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Fix ref in types #668

merged 1 commit into from
Jan 2, 2022

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Follow up to #666 (comment) removing ref from element props.
Leverages ComponentPropsWithoutRef which is a wrapper around IntrinsicElements which picks component properties from it.

@ChristianMurphy ChristianMurphy added the ☂️ area/types This affects typings label Dec 31, 2021
@ChristianMurphy ChristianMurphy requested review from remcohaszing and a team December 31, 2021 21:40
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 31, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy force-pushed the types/remove-ref-from-instrinsic-reflection branch from b3c04c5 to 9800c41 Compare December 31, 2021 21:42
@ChristianMurphy ChristianMurphy linked an issue Dec 31, 2021 that may be closed by this pull request
TypeError when using react-syntax-highlighter #666
Closed
4 tasks
@ChristianMurphy ChristianMurphy added the 👶 semver/patch This is a backwards-compatible fix label Dec 31, 2021
@wooorm wooorm changed the title types: remove ref from html attributes reflected from instrinsic elements Fix ref in types Jan 2, 2022
@wooorm wooorm merged commit 656a4fa into remarkjs:main Jan 2, 2022
@wooorm wooorm added the 💪 phase/solved Post is done label Jan 2, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 2, 2022
@wooorm
Copy link
Member

wooorm commented Jan 2, 2022

Released in 7.1.2!

@ChristianMurphy ChristianMurphy deleted the types/remove-ref-from-instrinsic-reflection branch January 2, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@remcohaszing remcohaszing remcohaszing approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when using react-syntax-highlighter
4 participants
@ChristianMurphy @codecov-commenter @wooorm @remcohaszing