Merge master back into our fork. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses (#1114) * remove references to constant special symbols * refactor CopyGenerator to not require tgt_dict, inputters.PAD_WORD * fix incorrect documentation * remove hard-coded specials from model_builder * remove unused methods and attributes * fix spelling error * remove hard-coded special tokens from loss computation * remove hard-coded special tokens * do not hardcode unk with 0 * use assert instead of raise AssertionError * remove meaningless line in save_fields_to_vocab, use list comprehension * refactor merge_vocabs to make it private and not depend on hard-coded special tokens * simplify load_vocabulary * fix load_vocabulary bug * remove UNK, which is unused * remove get_num_features * remove unused ShardedCorpusIterator and similar, update comments * fix variable name, update test_models.py * remove continuation-line ternary * fix error message spacing * fix rnn dim check * make long args lists vertical
* Make MultipleOptimizer expose a param_group attribute This allows to use the same learning rate update for all optimizers. * Harmonize learning rate decay definition * Make each method compute a scaling factor for the given step * Implement the general learning rate decay as a single formula * Set initial_accumulator_value argument for Adagrad * Remove params attribute from the Optimizer class The parameters are already stored in the underlying optimizer.
* remove make_text_examples * remove make_image_examples * remove make_audio_examples * remove building dataset from iterator * remove TextDataset.make_iterator_from_file, combine with make_examples * combine image's make_iterator_from_file and make_examples * rename AudioDataset method * unify dataset constructors * move _dynamic_dict to DatasetBase * fix import bug * fix import error (for real this time) * change dynamic_dict default value * dataset creation with iterators (except audio) * remove hard-coded specials from _dynamic_dict * do not split in _read_file * update src argument * fix silly error * remove print
* introducing Adafactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.