File tree 3 files changed +14
-1
lines changed
3 files changed +14
-1
lines changed Original file line number Diff line number Diff line change @@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
5
5
6
6
## [ unreleased]
7
7
8
+ - Fix regression in ` SemanticLogger::Appenders#close `
9
+
8
10
## [ 4.16.0]
9
11
10
12
- Add appender for Honeybadger Insights using the events API
Original file line number Diff line number Diff line change @@ -49,7 +49,7 @@ def close
49
49
closed_appenders = [ ]
50
50
each do |appender |
51
51
logger . trace "Closing appender: #{ appender . name } "
52
- appenders << appender
52
+ closed_appenders << appender
53
53
appender . flush
54
54
appender . close
55
55
rescue Exception => e
Original file line number Diff line number Diff line change @@ -100,5 +100,16 @@ class AppendersTest < Minitest::Test
100
100
# assert_instance_of SemanticLogger::Appender::Async, appender
101
101
# end
102
102
end
103
+
104
+ describe "#close" do
105
+ it "closes appenders" do
106
+ appender = appenders . add ( file_name : "test.log" )
107
+
108
+ appenders . close
109
+
110
+ assert_equal 0 , capture_logger . events . count { |it | it . message . match? ( /failed/i ) }
111
+ assert_equal 0 , appenders . size
112
+ end
113
+ end
103
114
end
104
115
end
You can’t perform that action at this time.
0 commit comments