Skip to content

Commit 093c025

Browse files
committed
fix: Use correct varname for closed appenders
Regression: f7d54bf
1 parent 364f3b9 commit 093c025

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
55

66
## [unreleased]
77

8+
- Fix regression in `SemanticLogger::Appenders#close`
9+
810
## [4.16.0]
911

1012
- Add appender for Honeybadger Insights using the events API

lib/semantic_logger/appenders.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def close
4949
closed_appenders = []
5050
each do |appender|
5151
logger.trace "Closing appender: #{appender.name}"
52-
appenders << appender
52+
closed_appenders << appender
5353
appender.flush
5454
appender.close
5555
rescue Exception => e

test/appenders_test.rb

+11
Original file line numberDiff line numberDiff line change
@@ -100,5 +100,16 @@ class AppendersTest < Minitest::Test
100100
# assert_instance_of SemanticLogger::Appender::Async, appender
101101
# end
102102
end
103+
104+
describe "#close" do
105+
it "closes appenders" do
106+
appender = appenders.add(file_name: "test.log")
107+
108+
appenders.close
109+
110+
assert_equal 0, capture_logger.events.count { |it| it.message.match?(/failed/i) }
111+
assert_equal 0, appenders.size
112+
end
113+
end
103114
end
104115
end

0 commit comments

Comments
 (0)