Skip to content

Commit fc15cd6

Browse files
authored
Merge pull request #69 from regulusweb/fix/contact-body-escape
Fix rendering of special characters in plain text email body.
2 parents ac7c410 + 9074187 commit fc15cd6

File tree

3 files changed

+3
-22
lines changed

3 files changed

+3
-22
lines changed

tests/test_tags.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from wagtail.core.models import Page
88
from wagtail_extensions.templatetags.wagtailextensions_tags import (
9-
bleachclean, page_menu_children, track_form_submission, menu)
9+
page_menu_children, track_form_submission, menu)
1010

1111

1212
@pytest.mark.django_db
@@ -42,18 +42,6 @@ def func(template_string):
4242
return func
4343

4444

45-
def test_bleanclean_cleandata():
46-
cleaned = bleachclean('Hello')
47-
48-
assert cleaned == 'Hello'
49-
50-
51-
def test_bleanclean_strips():
52-
cleaned = bleachclean('<script>evil</script>')
53-
54-
assert cleaned == 'evil'
55-
56-
5745
def test_track_form_submission(rf):
5846
request = rf.get('/')
5947
request.session = {
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
{% load bleachclean from wagtailextensions_tags %}
2-
31
{% autoescape off %}
42
Enquiry from {{ name }} ({{ email }}):
5-
{% endautoescape %}
63

7-
{{ message|bleachclean }}
4+
{{ message|striptags }}
5+
{% endautoescape %}

wagtail_extensions/templatetags/wagtailextensions_tags.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,6 @@ def humanize_date_range(start, end):
4848
return "{} - {}".format(start.strftime(start_fmt), end.strftime(day_fmt))
4949

5050

51-
@register.filter
52-
def bleachclean(value):
53-
return bleach.clean(value, strip=True)
54-
55-
5651
@register.simple_tag
5752
def block_method(block_value, method_name):
5853
method = getattr(block_value.block, method_name)

0 commit comments

Comments
 (0)