Enhancements for dtls.SCTPConn #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtls.SCTPConn is the net.Conn returned from gotapdance.Dial for the Conjure protocol with the DTLS transport. Callers may expect that net.Conn to behave as a TCP-like byte stream, and not an SCTP message stream, and these changes accomodate that. These changes should also be appropriate for use of dtls.SCTPConn on the station side. - Skip 0-byte writes - Buffer reads, allowing the caller to read smaller amounts of bytes without hitting the "short buffer" error - Add write flow control to avoid possibly unbounded outbound packet buffering
mingyech
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtls.SCTPConn is the net.Conn returned from gotapdance.Dial for the Conjure protocol with the DTLS transport. Callers may expect that net.Conn to behave as a TCP-like byte stream, and not an SCTP message stream, and these changes accomodate that. These changes should also be appropriate for use of dtls.SCTPConn on the station side.