Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace backslash with forward slash #379

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Jan 18, 2024

I'm not crazy about this fix, but it's a short term solution.

Ideally we can rewrite the path handling stuff using pathlib, and then get these uri-style paths via as_posix API.

CI runs still failing though: https://github.com/reflex-dev/reflex/actions/runs/7566517188/job/20604025206?pr=2414#step:8:2697

[Error: EMFILE: too many open files, open 
'D:\a\reflex\reflex\reflex-web\.web\node_modules\next\dist\server\require-hook.
js'] {
  errno: -4066,
  code: 'EMFILE',
  syscall: 'open',
  path: 
'D:\\a\\reflex\\reflex\\reflex-web\\.web\\node_modules\\next\\dist\\server\\req
uire-hook.js'
}

I'm seeing this even on my local windows VM as well.

Avoid EMFILE errors when building reflex-web on windows during CI.

reflex-web has too many pages and causes too many files to get opened during
the build, and windows seems to have a non-configurable limit for open file
handles via the C runtime.

Until we come up with a nicer solution, simply disallow windows builds. If the
override environment variable is set (like in CI runs), then we will compile a
subset of pages for testing.
@masenf masenf force-pushed the masenf/windows-path-fix branch from 1b0f77c to 2fc366a Compare January 22, 2024 22:16
@picklelo picklelo merged commit d9fa9dc into main Jan 24, 2024
1 check passed
@picklelo picklelo deleted the masenf/windows-path-fix branch January 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants