Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipes-functions]Adding sha256sum and sums functions #341

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

pratikmota
Copy link
Contributor

Changes:

  1. Adding sha256sum function
  2. Adding sha256sums function

Testing:
image

sha256sums function - for verification, i created a local test.txt file and checked.

Doubt:

  1. Do we require to use every time pipes/echo ? If i try to use rye .needs { pipes } and then directly echo "hello" then it is not working. Is it correct? or some other way we have to use?
    image

  2. For all builtins_pipes.go functions, we do not have any unit test cases. Can you suggest me at which place we can add testcase for pipes, if needed? So from next PR i will add unit test cases.

@pratikmota pratikmota marked this pull request as ready for review September 7, 2024 11:23
@refaktor
Copy link
Owner

refaktor commented Sep 8, 2024

pipes is it's own context so you can use pipes/echo to call it from outside or move to subcontext in repl (like cd, but cc) uring cc pipes echo "hello" |out. On in code use do\par or do\in do\par pipes { echo "lol" |out }

Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@refaktor refaktor merged commit 57b8098 into refaktor:main Sep 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants