Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/function support #308

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

yumaikas
Copy link
Contributor

No description provided.

@refaktor
Copy link
Owner

Hi, great! ... can you put the to-eyr back. I just recently started experimenting with compiling Rye to Eyr which is this code (still work in progress) and I don't want it removed :)

@refaktor
Copy link
Owner

For golangci-lint check to pass you can run bin/golangci-lint run and fix what it reports (some unreachable return).

@yumaikas
Copy link
Contributor Author

yumaikas commented Aug 12, 2024

Hi, great! ... can you put the to-eyr back. I just recently started experimenting with compiling Rye to Eyr which is this code (still work in progress) and I don't want it removed :)

How do you feel about moving it to it's own file for the time being, since an interpreter can look rather different from a compiler? If not, I can add it back, just thinking about keep from stepping on each other's toes

@refaktor
Copy link
Owner

Yes, good idea. Will you move it to it's own file of should I?

@yumaikas
Copy link
Contributor Author

I can do the movement later today

@refaktor refaktor merged commit f525306 into refaktor:main Aug 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants