Address #305: function names in error messages #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions are named incorrectly in their own error messages.
Examples:
- split\every appears as "split-every" in its own error messages
- most of the cases I found have this form: backslash appears as
hyphen
- to-eyr and eyr\full both appear as "eyr"
- this appears to be a copy/paste issue; there are some other
occurrences
- near-zero appears as "is-zero"
- perhaps an artifact of a renaming
- this function's descriptive string was also wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions are named incorrectly in their own error messages.
Examples:
The commit contains the cases that I found. I don't have a systematic way to check all the error messages, so there are probably still some more cases.