-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build and publish docker images through github CI #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update, I will test it soon with new release!
Not sure this is needed, as images are already built and published using goreleaser: Lines 63 to 72 in 9a67814
See https://github.com/refaktor/rye/pkgs/container/rye It
|
@booniepepper, can you please check if the existing released images at https://github.com/refaktor/rye/pkgs/container/rye are ok or is there something that should be changed / improved? See https://github.com/refaktor/rye?tab=readme-ov-file#binary-docker-image |
There is some detail in #194 on testing previous versions and version 0.0.19 If there's something more specific, please create an issue, and I can take a look. I will almost certainly lose track of a conversation in a closed pull request |
As far as i can tell the issue described in linked #194 now works fine:
and
If this was the only problem i guess the changes from this PR can be safely reverted to prevent any conflicts with images built by goreleaser. |
there was a error with release of new version and we think think it's related to this. Goreleaser should already publich to docker. We will check. More: #195
I'm not sure if this is related to #194 but I don't see automation yet for publishing docker images, and wanted to contribute it.
Also not sure of a great way to test things like this, but feel free to grab me on discord (
@booniepepper
) if there are any issues