Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Cleanup binaries #156

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Examples: Cleanup binaries #156

merged 1 commit into from
Mar 11, 2024

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Mar 11, 2024 •
edited
Loading

Removing 2 executable files:

  • examples/smtp-reciever/example: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=LUng083wdWeHjT0S9a1y/tlnbJixs0OpxLu55KqfL/4SyXP9FTpOnlCQz_E3JV/qyhWbl8w6Ft229nxPCTZ, with debug_info, not stripped
  • examples/smtp-reciever/smtp-reciever: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=x1BfDPgLqqU1tyP6akKW/TGdzqbgzkQa31DeTw0xZ/4SyXP9FTpOnlCQz_E3JV/dxGeeyPLvPi7yyzbDScB, with debug_info, not stripped

Both were added in 325cfa4, probably not intentionally.

@stefanb
Cleanup binaries
c89d0f1 
examples/smtp-reciever/example:           ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=LUng083wdWeHjT0S9a1y/tlnbJixs0OpxLu55KqfL/4SyXP9FTpOnlCQz_E3JV/qyhWbl8w6Ft229nxPCTZ, with debug_info, not stripped
examples/smtp-reciever/smtp-reciever:     ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=x1BfDPgLqqU1tyP6akKW/TGdzqbgzkQa31DeTw0xZ/4SyXP9FTpOnlCQz_E3JV/dxGeeyPLvPi7yyzbDScB, with debug_info, not stripped
@stefanb stefanb changed the title Cleanup binaries Cleanup example binaries Mar 11, 2024
@stefanb stefanb changed the title Cleanup example binaries Examples: Cleanup binaries Mar 11, 2024
refaktor
refaktor approved these changes Mar 11, 2024
View reviewed changes
Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I've somehow missed those. Thank you!

@refaktor refaktor merged commit c6fe4d2 into refaktor:main Mar 11, 2024
7 checks passed
@stefanb stefanb deleted the cleanup-binaries branch March 11, 2024 11:32
@stefanb
Copy link
Contributor Author

stefanb commented Mar 11, 2024

I noticed it in the scoreboard, because Binary-Artifacts was not getting full 10 points as it does now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refaktor refaktor refaktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanb @refaktor