Improve set functions #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refaktor
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Thank you! Great updates and good finds about the idiosyncrasies around lists and blocks, it makes more sense this way, yes! And thank you for syncing all the tests and also docstrings.
The docstrings are our weak spot, so maybe there should be a PR rule, that anyone who makes a builitin function also writes it. It beats TODODOC as I previously said it can be set to :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
differenceset function and cleans up theunionandintersectionand make them more performant.It changes the behavior for set operations on
env.List: before the second argument wasenv.Blockbut I changed it to also beenv.Listbecause it makes more sense to me. If there's a reason why it was like that before I can change it back.