.golangci.yml

linters-settings:
  depguard:
    # new configuration
    rules:
      logger:
        deny:
          # logging is allowed only by logutils.Log,
          # logrus is allowed to use only in logutils package.
          - pkg: "github.com/sirupsen/logrus"
            desc: logging is allowed only by logutils.Log
  dupl:
    threshold: 100
  funlen:
    lines: -1 # the number of lines (code + empty lines) is not a right metric and leads to code without empty line or one-liner.
    statements: 50
  goconst:
    min-len: 2
    min-occurrences: 3
  gocritic:
    enabled-tags:
      - diagnostic
      - experimental
      - opinionated
      - performance
      - style
    disabled-checks:
      - dupImport # https://github.com/go-critic/go-critic/issues/845
      - ifElseChain
      - octalLiteral
      - whyNoLint
  gocyclo:
    min-complexity: 15
  gofmt:
    rewrite-rules:
      - pattern: 'interface{}'
        replacement: 'any'
  goimports:
    local-prefixes: github.com/refaktor/rye
  gomnd:
    # don't include the "operation" and "assign"
    checks:
      - argument
      - case
      - condition
      - return
    ignored-numbers:
      - '0'
      - '1'
      - '2'
      - '3'
    ignored-functions:
      - strings.SplitN

  govet:
    check-shadowing: true
    settings:
      # printf:
      #   funcs:
      #     - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
      #     - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
      #     - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
      #     - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
  lll:
    line-length: 140
  misspell:
    # locale: US # or UK, uncomment if want to be picky about colour/color behaviour/behavior
  nolintlint:
    allow-unused: false # report any unused nolint directives
    require-explanation: false # don't require an explanation for nolint directives
    require-specific: false # don't require nolint directives to be specific about which linter is being skipped
  revive:
    rules:
      - name: unexported-return
        disabled: true
      - name: unused-parameter
  gosec:
    exclude-rules:
      - G504


linters:
  disable-all: true
  enable:
    # - bodyclose ... some functions can't clsoe a body themselves because it will have to be read from another function
    - depguard
    - dogsled
    # - dupl
    - errcheck
    # - exportloopref -- no more on 1.23.1
    # - funlen
    #- gocheckcompilerdirectives --x
    - gochecknoinits
    # - goconst
    # - gocritic
    # - gocyclo
    - gofmt
    - goimports
    # - gomnd
    - goprintffuncname
    - gosec
    # - gosec -exclude=G504
    - gosimple
    - govet
    - ineffassign
    # - lll
    - misspell
    # - nakedret
    # - noctx --- x
    # - nolintlint --- x
    # - revive
    - staticcheck
    # - stylecheck
    # - typecheck # --- temporarily removed, was throwing weird errors after upgrade to 1.23.1 on 20240925
    - unconvert
    # l1 - unparam
    # - unused
    - whitespace

  # don't enable:
  # - asciicheck
  # - scopelint
  # - gochecknoglobals
  # - gocognit
  # - godot
  # - godox
  # - goerr113
  # - interfacer
  # - maligned
  # - nestif
  # - prealloc
  # - testpackage
  # - wsl

issues:
  # Excluding configuration per-path, per-linter, per-text and per-source
  exclude-rules:
#    - text: "evaldo"
#      linters: typecheck
    - text: "net/http/cgi" # REASON: only important for Go 1.6 and lower, Rye requires go1.8 or higher as defined in go.mod
      linters: gosec 

    # - path: _test\.go
    #   linters:
    #     - gomnd

    # - path: pkg/golinters/errcheck.go
    #   text: "SA1019: errCfg.Exclude is deprecated: use ExcludeFunctions instead"
    # - path: pkg/commands/run.go
    #   text: "SA1019: lsc.Errcheck.Exclude is deprecated: use ExcludeFunctions instead"
    # - path: pkg/commands/run.go
    #   text: "SA1019: e.cfg.Run.Deadline is deprecated: Deadline exists for historical compatibility and should not be used."

    # - path: pkg/golinters/gofumpt.go
    #   text: "SA1019: settings.LangVersion is deprecated: use the global `run.go` instead."
    # - path: pkg/golinters/staticcheck_common.go
    #   text: "SA1019: settings.GoVersion is deprecated: use the global `run.go` instead."
    # - path: pkg/lint/lintersdb/manager.go
    #   text: "SA1019: (.+).(GoVersion|LangVersion) is deprecated: use the global `run.go` instead."
    # - path: pkg/golinters/unused.go
    #   text: "rangeValCopy: each iteration copies 160 bytes \\(consider pointers or indexing\\)"
    # - path: test/(fix|linters)_test.go
    #   text: "string `gocritic.go` has 3 occurrences, make it a constant"

run:
  timeout: 5m
  # skip-dirs:
  #   - test/testdata_etc # test files
  #   - internal/cache # extracted from Go code
  #   - internal/renameio # extracted from Go code
  #   - internal/robustio # extracted from Go code