Skip to content

#62 mvn site and #70 GH buttons on mvn site generated page #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2023

Conversation

jimbethancourt
Copy link
Collaborator

Now generating report through mvn site command. Added GH buttons to mvn site command generated webpage

- mvn clean site now behaves as expected
- Renamed the report goal to htmlReport
- Justifications in Maven report table are correct
Couldn't figure out how to render "async defer" as part of the script import, but the buttons seem to work ok without those two keywords.
@ghost
Copy link

ghost commented Oct 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jimbethancourt jimbethancourt merged commit bcbc9d4 into main Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant