Skip to content

Commit

Permalink
src: simplify uptime and ppid return values
Browse files Browse the repository at this point in the history
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().

PR-URL: nodejs#24562
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information
cjihrig authored and refack committed Jan 10, 2019
1 parent a8b3504 commit c1d374d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/node_process.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ using v8::Integer;
using v8::Isolate;
using v8::Local;
using v8::Name;
using v8::Number;
using v8::PropertyCallbackInfo;
using v8::String;
using v8::Uint32;
Expand Down Expand Up @@ -259,7 +258,7 @@ void Uptime(const FunctionCallbackInfo<Value>& args) {
uv_update_time(env->event_loop());
uptime = uv_now(env->event_loop()) - prog_start_time;

args.GetReturnValue().Set(Number::New(env->isolate(), uptime / 1000));
args.GetReturnValue().Set(uptime / 1000);
}


Expand Down Expand Up @@ -790,7 +789,7 @@ void EnvEnumerator(const PropertyCallbackInfo<Array>& info) {

void GetParentProcessId(Local<Name> property,
const PropertyCallbackInfo<Value>& info) {
info.GetReturnValue().Set(Integer::New(info.GetIsolate(), uv_os_getppid()));
info.GetReturnValue().Set(uv_os_getppid());
}

void GetActiveRequests(const FunctionCallbackInfo<Value>& args) {
Expand Down

0 comments on commit c1d374d

Please sign in to comment.