Skip to content

Commit 09bf8af

Browse files
Fix resource policy accessibility issues
1 parent 57cc34c commit 09bf8af

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

src/app/shared/resource-policies/entry/resource-policy-entry.component.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
[id]="entry.id"
66
[ngModel]="entry.checked"
77
(ngModelChange)="this.toggleCheckbox.emit($event);">
8-
<label class="custom-control-label" [for]="entry.id"></label>
8+
<label class="custom-control-label" [for]="entry.id"
9+
[attr.aria-label]="(entry.checked ? 'resource-policies.table.headers.deselect' : 'resource-policies.table.headers.select') | translate">
10+
</label>
911
</div>
1012
</td>
1113
<th scope="row">

src/app/shared/resource-policies/resource-policies.component.html

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,13 @@
3838
<tr *ngIf="(getResourcePolicies() | async)?.length > 0" class="text-center">
3939
<th>
4040
<div class="custom-control custom-checkbox">
41-
<input type="checkbox"
41+
<input #selectAllBtn type="checkbox"
4242
class="custom-control-input"
4343
[id]="'selectAll_' + resourceUUID"
4444
(change)="selectAllCheckbox($event)">
45-
<label class="custom-control-label" [for]="'selectAll_' + resourceUUID"></label>
45+
<label class="custom-control-label" [for]="'selectAll_' + resourceUUID"
46+
[attr.aria-label]="(selectAllBtn.checked ? 'resource-policies.table.headers.deselect-all' : 'resource-policies.table.headers.select-all') | translate">
47+
</label>
4648
</div>
4749
</th>
4850
<th>{{'resource-policies.table.headers.id' | translate}}</th>

src/assets/i18n/en.json5

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3610,6 +3610,14 @@
36103610

36113611
"resource-policies.table.headers.group": "Group",
36123612

3613+
"resource-policies.table.headers.select-all": "Select all",
3614+
3615+
"resource-policies.table.headers.deselect-all": "Deselect all",
3616+
3617+
"resource-policies.table.headers.select": "Select",
3618+
3619+
"resource-policies.table.headers.deselect": "Deselect",
3620+
36133621
"resource-policies.table.headers.id": "ID",
36143622

36153623
"resource-policies.table.headers.name": "Name",

0 commit comments

Comments
 (0)