Fix soundness bug in NotNan::cmp. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrubeck
force-pushed
the
partial_cmp
branch
3 times, most recently
from
712389b
to
37cd73b
Compare
|
Unfortunately this may cause a performance regression, but I don't think there is an alternative that is both sound and backward-compatible. The regression could be fixed if impl specialization were available on stable Rust. |
mbrubeck
force-pushed
the
partial_cmp
branch
2 times, most recently
from
315ab14
to
9593cb8
Compare
Ill-behaved FloatCore implementations for user types could have `x.partial_cmp(&x) == None` even when `x.is_nan() == false`. This crate will now panic in those cases, rather than execute undefined behavior. Fixes #150.
mbrubeck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ill-behaved FloatCore implementations for user types could have
x.partial_cmp(&x) == Noneeven whenx.is_nan() == false. This crate will now panic in those cases, rather than execute undefined behavior.Fixes #150.