-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on VSCode folder-/watcher-ignore settings to "Project Configuration" docs (using .yarn
-folder as an example)
#5868
Conversation
✅ Deploy Preview for redwoodjs-docs canceled.
|
Hey @Philzen. I like the idea of excluding the yarn binary from search, but removing the |
@jtoar would need some investigation on that. But ask yourself: Did you ever in your life have to go into the I couldn't think of any scenario where i'd need that, for me it just clutters the DX, but maybe you know a actual use case for it being there. For me, it's a bazillion times more likely that i'd want to go into the |
I've used My concern is that this sounds like it count as adding magic to the framework. We show other dot directories that you're not really supposed to edit (but can for educational or debugging purposes). Namely,
That's a fair point! But VSCode hides the I appreciate the effort towards improving the DX, no matter how little, but on this particular change, I'm still unconvinced. So let's see if we can get some others to chime in. |
IMHO the whole RedwoodJS stack is magic ;)
I have briefly looked into various posts on the question earlier (there's numerous on that) but none seemed to give a crystal clear answer on how to do that and i felt it would require some thorough testing to find the right config (provided it's actually possible).
Not sure if that was the most convincing argument to keep it in the directory listing 😆 – but surely honest though 🤝 I doubt anybody else – the consumers of RedwoodJS – ever really want to see that folder – they only care that it works and we provide them with a stable setup. Should they ever want to look into it – well there a plenty of options, and just like you would use those when intending to work inside the
Yes, but that one is really important to have imho – because VSCode navigates there all the time when a i click on a type to look up it's definition, so there is no doubt it is a real benefit to have it available. With all of the above said i don't hold a very strong opinion on this topic or want to get my PR through at all costs – as a user i have already done that setting, never regretted it and simply wanted to share it – though i'd prefer not having to repeat it everytime i create a new redwood project 😉 I'm looking forward to more opinions on this though. |
For sure! And much appreciated, thanks for sharing—it's definitely hard for me to take my rwjs-framework-developer hat off as you said, and my "is this going to move the needle" hat off. I'll try to get more of the team's eyes on this! |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e8be9e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
@Philzen I brought this up today with @Tobbe and we just don't think it's a good idea to make changes to the template if it's not a clear win / the majority of the community doesn't desperately need it. But we thought it may be a good idea to start collecting opt-in DX configurations like this though. Would you want to add a section to https://redwoodjs.com/docs/project-configuration-dev-test-build that talks about configuring your project? |
e15c92d
to
967ced2
Compare
I finally got around to write the requested section. This actually required some deep-dive into how config inheritance and Learned along the way (by experimentation) that VSCode doesn't try to really parse the Realized the other day that i can simply have it my way via a global setting in my user @jtoar @Tobbe Kindly review and request any changes to the wording as you see fit. I completely fine with anybody pushing updates directly to improve upon this, as i'll be off for a couple of days from Thursday on, but would also love to get this finally merged soon (another tick in the box). |
.yarn
-folder as an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate all the effort you put into this @Philzen. Reading it all, I think I'm probably going to enable this for my RW app projects 👍 Just had a couple of comments for you to look at
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
- fix a typo - add command key combination for Mac - Reorder the ordered list so it matches the following subheadings order
Looks good to me, but let's give @jtoar some time to review if he wants. He's got a way with words that I lack 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @Philzen! Making some small edits I'll commit then reread again; I'll get this one in shortly.
Make VSCode ignore the
.yarn
-folder and thus exclude it from parsing.Some more zen for the DX – and i guess some cpu cycles saved as VSCode won't try to
discover and parsewatch and search a 2.1MB javascript executable.In the least it doesn't hurt to exclude this from the IDE – unless someone knows and actual need to do something in the
.yarn
-folder via VSCode.