Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl Click/ F12 on a function doesn't take you to definition (vs code) #669

Closed
goleary opened this issue Jun 8, 2020 · 4 comments
Closed
Labels
bug/confirmed We have confirmed this is a bug topic/fully-integrated-dx

Comments

@goleary
Copy link

goleary commented Jun 8, 2020

When I Ctrl+ click a function or component in VS Code (or use F12) I'm taken to the import statement at the top of the file I'm already in, not the definition in that file. I figured maybe this had to do with the src/... aliasing, but even when I import regularly this is still happening.

https://code.visualstudio.com/docs/editor/editingevolved#_go-to-definition

This makes it difficult to get to the definition of a function/component.

vs code 1.45.1
windows 10

@peterp peterp self-assigned this Jun 9, 2020
@peterp
Copy link
Contributor

peterp commented Jun 9, 2020

I'll take a look at this, thanks for reporting it!

@peterp peterp added the bug/repro-available A reproduction exists and needs to be confirmed label Jun 9, 2020
@jtoar jtoar added bug/confirmed We have confirmed this is a bug and removed bug/repro-available A reproduction exists and needs to be confirmed labels May 27, 2021
@jtoar
Copy link
Contributor

jtoar commented May 27, 2021

Here's an example I came across:

go-to-def.mp4

@Tobbe
Copy link
Member

Tobbe commented May 28, 2021

This is one of the things I miss the most when working on a RW project compared to say a CRA project. Thankfully it's going to be solved by our TS efforts. It's the second to last item here #234 (comment)

@dac09
Copy link
Collaborator

dac09 commented Jun 4, 2021

Fixed in #2614 !! 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/fully-integrated-dx
Projects
None yet
Development

No branches or pull requests

5 participants