Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in scaffold styling #5116

Closed
Tobbe opened this issue Apr 11, 2022 · 2 comments · Fixed by #5136
Closed

Regression in scaffold styling #5116

Tobbe opened this issue Apr 11, 2022 · 2 comments · Fixed by #5136

Comments

@Tobbe
Copy link
Member

Tobbe commented Apr 11, 2022

We used to have alternating background colors in scaffolded tables. At some point we lost that. Also lost rounded corners and the outline.

Before:
image

Now:
image

I think we should bring back the old styles.
@ccnklc
Copy link
Contributor

ccnklc commented Apr 12, 2022

Hi @Tobbe ,If this is still free to pick, I can take this issue as part of my first contribution to Redwood repo.

@Tobbe
Copy link
Member Author

Tobbe commented Apr 12, 2022

@ccnklc Yes, please do! And just ask if you have any questions at all along the way 🙂

This was referenced Apr 12, 2022
Merged
Closed
@jtoar jtoar linked a pull request Apr 15, 2022 that will close this issue
Update scaffold css files to add bg to odd rows and border to segment #5136
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update scaffold css files to add bg to odd rows and border to segment ccnklc/redwood
3 participants
@Tobbe @ccnklc @jtoar