-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint for case-sensitive imports #2806
Comments
Just going to stress that this really can take hours/days! Especially these days when most devs are constantly context switching. Any tooling to help catch insidious behaviour like this will be amazing! Thank you upfront ✌🏾 🙏🏾 |
I'd like us to prioritize this for v1-rc |
@jtoar @thedavidprice Can we use |
@callingmedic911 sorry for the delayed reply here. That plugin looks like a good option to explore. My only initial concern (without having researched yet) is that the plugin could collide with some of Redwood's import conventions, e.g. "directory named" convention might have some static analysis issues. I think the best way to find out would be to open a PR and show a screenshot of the behavior so we can determine if it's what we want. If we have to disable a lot of defaults, it might not be the right fit. But either way odds are you'll learn what the right solution could be. So please go for it if you're up for it! |
@thedavidprice You are absolutely right! "directory named" and Also, if we decide to go ahead with the custom lint rule, we can merge
|
@peterp given the nature of this potential bug, what do you think about this approach? And/or is there another way forward here? |
Since we recently added TS support for Redwood's directory structure, we seem to now be vulnerable to this bug: microsoft/TypeScript#21736. @KrisCoulson already ran into it, and it's super hard to debug (you think it's a webpack / fast refresh problem at first). This feels like something people could easily run into and spend hours trying to fix.
It seems like our best chance to prevent it is to have some kind of linting of our own. Thoughts?
The text was updated successfully, but these errors were encountered: