Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Flight control deployment not working #10754

Closed
1 task
ccnklc opened this issue Jun 8, 2024 · 2 comments · Fixed by #11383
Closed
1 task

[Bug?]: Flight control deployment not working #10754

ccnklc opened this issue Jun 8, 2024 · 2 comments · Fixed by #11383
Assignees
Labels
bug/needs-info More information is needed for reproduction topic/deployment

Comments

@ccnklc
Copy link
Contributor

ccnklc commented Jun 8, 2024

What's not working?

When you setup flightcontrol deployment with postgres

these settings doesn't work, apparently RDS cannot create a db with these settings, it needs an update.

      "engine": "postgres",
      "engineVersion": "12",
      "instanceSize": "db.t2.micro",
      "storage": 20,

How do we reproduce the bug?

setup an app try to deploy it with flightcontrol to aws

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@ccnklc ccnklc added the bug/needs-info More information is needed for reproduction label Jun 8, 2024
@ccnklc
Copy link
Contributor Author

ccnklc commented Jun 8, 2024

More info for you,

Redwood generates flightcontrol.json to manage which aws services will be automated by flightcontrol.

In the json file everything looks fine, however the part for RDS settings the one I have shared in the main bug ticket is not accepted by AWS as they state there is no matching combination of RDS with engine= postgres, version= '12', instance size =db.t2.micro and storage=20 , I checked the AWS docs quickly but there was a lot of things to check so i let it go deployed to vercel again.

Someone who uses AWS daily, needs to check this config and update it to what is expected by AWS.

@Josh-Walker-GM
Copy link
Collaborator

Josh-Walker-GM commented Jun 10, 2024

Hey @ccnklc 👋

Are you able to still try deploying with a change to the generated config?

I think we might just need to change away from t2 instance types. The AWS docs here state that creating t2 db instance types is no longer supported.
image

My suggestion would be to switch from:

"instanceSize": "db.t2.micro",

to

"instanceSize": "db.t4g.micro",

Postgres version 12 is also now about 5 years old. AWS lets me create a postgres instance with version 16 so I too might be in favour of updating that option.

Don't worry if not. We can find some time ourselves to setup a project/deployment and confirm the changes work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction topic/deployment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants