Fix TypeScript tests to pass for new TypeScript definitions #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reduxjs#1569) * throw error if getState, subscribe, or unsubscribe called while dispatching * prevent throwing if not subscribed * update getState error message * fix space after period * update subscribe/unsubscribe error messages
* Add a doc section on dispatching during middleware setup. * Warn when dispatching during middleware setup. * Upgrade the warning to an error. * Update docs to match thrown error behavior.
* Add mapped type for combineReducers in index.d.ts Updated typescript to 2.1.4 Updated typescript-definition-tester to 0.0.5 Updated typescript tests to use proper import Added mapped type to index.d.ts * add strict null check for reducer Updated Reducer<S> type in index.d.ts Add strictNullChecks flag to typescript spec
Behavior has been replaced with the "it warns when dispatching during middleware setup" test in the 'next' branch.
* Revamp TypeScript typing with more type safety * Provide a default action type for combineReducers * Change state default types to any * Don't parameterize Dispatch with a state type * Remove docstring about excised type parameter
|
|
timdorr
force-pushed
the
next
branch
2 times, most recently
from
761b399 to
ee1b0aa
Compare
|
I just updated the next branch against master. Can you redo this? We're not using yarn now that npm has lockfiles. |
|
BTW, looks like just b9278d1 is all we need in this PR. |
|
Just confused. |
|
Yes, sorry, I meant to close this out too. Thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typescript tests for new d.ts
Use prepare instead of prepublish in package.json (same as in master branch).
Update typescript in yarn.lock to comply to what's in package.json
I'm using the
nextbranch to have new d.ts and strongly typed actions.However wondering if the
nextbranch is going to be synced with the current master?