Add a warning for undefined properties passed to combineReducers #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof reducers[key] === 'undefined') { | ||
| warning(`No reducer provided for key "${key}"`) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: Do you mind adding newlines before and after this new block? It makes it easier to spot the dev-only code.
|
LGTM once we can get the style fixed up. |
|
Newlines added. 👍 |
|
Thanks! I'll tweak some of the messaging after-the-fact. |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
…uxjs#1789) * Add warning to combineReducers for undefined properties * Test that it warns for undefined reducer props * Duh remove only * add some newlines
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easy to accidentally do with import statements and
combineReducersdoesn't currently give any indication of anything going wrong, it just ignores properties that aren't functions.