Skip to content

Possible error in applyMiddlewares/createStore #2200

Closed
@fourlastor

Description

@fourlastor

I was checking out the source code for https://github.com/reactjs/redux/blob/master/src/applyMiddleware.js#L20 and https://github.com/reactjs/redux/blob/master/src/createStore.js#L50 and noticed one thing:

// createStore.js
return enhancer(createStore)(reducer, preloadedState);
// applyMiddleware.js
return (createStore) => (reducer, preloadedState, enhancer) => {

So as far as I understood, applyMiddleware's (and any store enhancer's) signature is (createStore) => createStore, while createStore is assuming (createStore) => (reducer, preloadedState).

Which one should be the correct one? I would assume (createStore) => createStore.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions