Skip to content

Support OpenAPI readOnly/writeOnly properties #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 10, 2023

Conversation

cvereterra
Copy link
Contributor

@cvereterra cvereterra commented May 9, 2023

Addresses #2742 in rtk-query-codegen-openapi

oazapfts added support for readOnly/writeOnly in v4.7.1. Relevant changes of this PR that must be looked at with care:

  • Upgraded oazapfts to 4.7.1
  • Upgraded typescript to ^5.0.4
  • Removed typescript check that enforced typescript version to be between 4.1 and 4.5. I'm sure that this check was there for a reason, I'm open to help.
  • @rtk-query/oazapfts-patched is not used anymore. If you need to, I can update the package to use oazapfts@4.7.1
  • Added a test for the readOnly/writeOnly API spec

Cheers

@codesandbox
Copy link

codesandbox bot commented May 9, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d00963:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 9d00963
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6525c58a2c5337000880cadf
😎 Deploy Preview https://deploy-preview-3430--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saschahofmann
Copy link

Oazapfts has released version 4.8 in the meantime and version 4.8.1 adds the option of using the OpenAPI 3.1 functionality of prefixItems that would also fix #3648.

Any blockers to upgrade to 4.8.1 here and merge this?

@phryneas
Copy link
Member

phryneas commented Oct 10, 2023

ugh, that merge went wrong somehow got it

@phryneas
Copy link
Member

This has taken far too long, I apologize!

Let's get this out as 1.1.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants