Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting client side exception in RTK query documentation #4632

Closed
Mohitkumar6122 opened this issue Sep 19, 2024 · 9 comments
Closed

Getting client side exception in RTK query documentation #4632

Mohitkumar6122 opened this issue Sep 19, 2024 · 9 comments

Comments

@Mohitkumar6122
Copy link

Attaching SS
image

@Mohitkumar6122
Copy link
Author

Here is the browser console SS

image

@markerikson
Copy link
Collaborator

That's an embed from Egghead, and not part of our docs directly. Don't think that's something we can fix ourselves.

@Mohitkumar6122
Copy link
Author

Mohitkumar6122 commented Sep 19, 2024

@markerikson Agreed
Also could you make a generic wrapper on the third party sources, you are using so that whenever a Client side excpection occured, it would give a alert to your devs ?
But can you raise this issue to there end ?

@markerikson
Copy link
Collaborator

We can't do anything about the error - it's just an embedded iframe:

<iframe 
    src="https://app.egghead.io/lessons/redux-course-introduction-and-application-walk-through-for-rtk-query-basics/embed?af=7pnhj6" 

But yeah, we can try to ping them.

@Mohitkumar6122
Copy link
Author

@markerikson I believe this is the best solution
But lets not close this issue until its fixed.
Since I visited redux website its your duty to maintain each and every page including the iframes embedded ?

@markerikson
Copy link
Collaborator

@Mohitkumar6122 I appreciate the enthusiasm, but this truly is a third-party problem. Yes, we embed the video player in our docs, but it's not our code and we can't fix it ourselves.

We try to only keep issues open if there's actually something we can do to fix a problem and we are still planning to do that thing, so in this case it's appropriate to close it.

@Mohitkumar6122
Copy link
Author

Thanks @markerikson for confirming

@phryneas
Copy link
Member

phryneas commented Sep 19, 2024

I gave the guys over at egghead a ping so they'll take a look.

Since I visited redux website its your duty to maintain each and every page including the iframes embedded ?

Meanwhile, can I offer you a refund of the money you paid to access our free content?
But on a more serious note: we do this for free, in our spare time. We do it for users like you. You're welcome, but please understand that nothing here is our "duty".

@Mohitkumar6122
Copy link
Author

@phryneas
Thank you for reaching out to egghead and for the quick response.

I completely understand and appreciate the hard work you and your team put into maintaining Redux, especially in your spare time. I apologize if my message came across as overly demanding—that wasn’t my intention. I’m not looking for a refund, as I highly value the free resources you provide.

My goal was simply to point out that when users encounter issues on the site, such as embedded content not working, it can reflect on the overall experience. I just wanted to raise awareness in case it's something that might need attention.

Thanks again for all your efforts, and I really appreciate your work for the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants