Skip to content

Commit 3929ef8

Browse files
committed
fix logic bug, overload for getRunningOperationPromise
1 parent 174c05a commit 3929ef8

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

packages/toolkit/src/query/core/buildInitiate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export function buildInitiate({
212212
function getRunningOperationPromise(
213213
endpointName: string,
214214
argOrRequestId: any
215-
) {
215+
): any {
216216
const endpointDefinition = context.endpointDefinitions[endpointName]
217217
if (endpointDefinition.type === DefinitionType.query) {
218218
const queryCacheKey = serializeQueryArgs({

packages/toolkit/src/query/core/buildSlice.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,8 @@ export function buildSlice({
249249
for (const [key, entry] of Object.entries(mutations)) {
250250
if (
251251
// do not rehydrate entries that were currently in flight.
252-
entry?.status === QueryStatus.fulfilled ||
253-
entry?.status === QueryStatus.rejected ||
252+
(entry?.status === QueryStatus.fulfilled ||
253+
entry?.status === QueryStatus.rejected) &&
254254
// only rehydrate endpoints that were persisted using a `fixedCacheKey`
255255
key !== entry?.requestId
256256
) {

packages/toolkit/src/query/core/module.ts

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ import type {
2020
FullTagDescription,
2121
} from '../endpointDefinitions'
2222
import { isQueryDefinition, isMutationDefinition } from '../endpointDefinitions'
23-
import type { CombinedState, QueryKeys, RootState } from './apiState'
23+
import type {
24+
CombinedState,
25+
QueryKeys,
26+
MutationKeys,
27+
RootState,
28+
} from './apiState'
2429
import type { Api, Module } from '../apiTypes'
2530
import { onFocus, onFocusLost, onOnline, onOffline } from './setupListeners'
2631
import { buildSlice } from './buildSlice'
@@ -267,13 +272,16 @@ declare module '../apiTypes' {
267272
: never
268273
}
269274
getRunningOperationPromises: () => Array<Promise<unknown>>
270-
getRunningOperationPromise: <EndpointName extends QueryKeys<Definitions>>(
275+
getRunningOperationPromise<EndpointName extends QueryKeys<Definitions>>(
271276
endpointName: EndpointName,
272277
args: QueryArgFrom<Definitions[EndpointName]>
273-
) =>
274-
| QueryActionCreatorResult<Definitions[EndpointName]>
275-
| MutationActionCreatorResult<Definitions[EndpointName]>
276-
| undefined
278+
): QueryActionCreatorResult<Definitions[EndpointName]> | undefined
279+
getRunningOperationPromise<
280+
EndpointName extends MutationKeys<Definitions>
281+
>(
282+
endpointName: EndpointName,
283+
fixedCacheKeyOrRequestId: string
284+
): MutationActionCreatorResult<Definitions[EndpointName]> | undefined
277285
}
278286
}
279287
}

0 commit comments

Comments
 (0)