Don't override ref property when not configured to.#2252
Open
PSpSynedra wants to merge 4 commits intoreduxjs:masterfrom
Open
Don't override ref property when not configured to.#2252PSpSynedra wants to merge 4 commits intoreduxjs:masterfrom
PSpSynedra wants to merge 4 commits intoreduxjs:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
Author
|
Unfortunately I cannot get the "Test Published Artifact expo (pull_request)" to pass. Can I run the failing test locally on my machine to fix the issue? |
1 task
✅ Deploy Preview for react-redux-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior of
connectis to always pass along a ref property, event when the optionforwardRefwas not truthy or preset.This pull request
undefinedref.The error in the following use case is also fixed with this pull-request:
NOTE:
My initial intend was to remove the use of
React.forwardRef(...)completely, but this would have broken the compatibility with React prior to version 19.