Skip to content

Port additional React-Redux TS typetests from DefinitelyTyped #1854

Closed
@markerikson

Description

@markerikson

We copied over a bunch of typetests for React-Redux as part of the TS conversion, which are currently here:

React-Redux: test/typetests/react-redux-typetests.tsx

However, I was just comparing that file with the typetests that are currently in DefinitelyTyped, and there's a big difference. Our current file is only around 500 lines, and the DT file is about 1600 lines:

DefinitelyTyped: react-redux/react-redux-typetests.tsx

We should review the DT typetest file and port over as much as possible, to ensure that the types we've ported and updated are thoroughly covered and don't break existing code. Also might be good to split the typetests into separate files (at a minimum one each for connect, useDispatch, and useSelector - maybe even further?) so it's easier to find a given section.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions