Optional peer dependencies are incorrectly listed in package.json #1559
Closed
Description
Currently react-dom
and react-native
are listed as optional peer dependencies of react-redux, but they are only listed in peerDependenciesMeta
and not in peerDependencies
. Looking at the RFC for optional peer dependencies in Yarn v2, I'm pretty sure the correct way is to list them in both fields:
yarnpkg/rfcs#105 (comment)
Consistent with this, I'm seeing yarn v2 (with pnp) complaining that A package is trying to access another package without the second one being listed as a dependency of the first one
, even when react-dom
is a dep of the react-redux
's direct ancestor.
Happy to provide a PR and\or a repro if you'd like!
redux: 4.0.5
react-redux: 7.2.0
react-dom: 16.12.0
Metadata
Assignees
Labels
No labels