Skip to content

Commit dbc9dec

Browse files
committed
Reverted changes to all spec files of this branch.
1 parent c2efa3a commit dbc9dec

File tree

5 files changed

+37
-40
lines changed

5 files changed

+37
-40
lines changed

test/components/Provider.spec.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
/*eslint-disable react/prop-types*/
22

3-
import * as React from 'react'
4-
import { Component, Dispatch, StrictMode } from 'react'
5-
import { render, unmountComponentAtNode } from 'react-dom'
3+
import React, { Component, Dispatch } from 'react'
4+
import ReactDOM from 'react-dom'
65
import { createStore } from 'redux'
76
import { Provider, connect, ReactReduxContext } from '../../src/index'
87
import * as rtl from '@testing-library/react'
@@ -312,18 +311,18 @@ describe('React', () => {
312311
})
313312

314313
it('works in <StrictMode> without warnings (React 16.3+)', () => {
315-
if (!StrictMode) {
314+
if (!React.StrictMode) {
316315
return
317316
}
318317
const spy = jest.spyOn(console, 'error').mockImplementation(() => {})
319318
const store = createStore(() => ({}))
320319

321320
rtl.render(
322-
<StrictMode>
321+
<React.StrictMode>
323322
<Provider store={store}>
324323
<div />
325324
</Provider>
326-
</StrictMode>
325+
</React.StrictMode>
327326
)
328327

329328
expect(spy).not.toHaveBeenCalled()
@@ -344,15 +343,15 @@ describe('React', () => {
344343
}
345344

346345
const div = document.createElement('div')
347-
render(
346+
ReactDOM.render(
348347
<Provider store={store}>
349348
<div />
350349
</Provider>,
351350
div
352351
)
353352

354353
expect(spy).toHaveBeenCalledTimes(0)
355-
unmountComponentAtNode(div)
354+
ReactDOM.unmountComponentAtNode(div)
356355
expect(spy).toHaveBeenCalledTimes(1)
357356
})
358357

test/components/hooks.spec.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
/*eslint-disable react/prop-types*/
22

3-
import * as React from 'react'
4-
import { useState, useEffect, version as reactVersion } from 'react'
3+
import React from 'react'
54
import { createStore } from 'redux'
65
import { Provider as ProviderMock, connect } from '../../src/index'
76
import * as rtl from '@testing-library/react'
87
import '@testing-library/jest-dom/extend-expect'
98
import type { AnyAction } from 'redux'
109

11-
const IS_REACT_18 = reactVersion.startsWith('18')
10+
const IS_REACT_18 = React.version.startsWith('18')
1211

1312
describe('React', () => {
1413
describe('connect', () => {
@@ -62,11 +61,11 @@ describe('React', () => {
6261
})
6362

6463
const component1 = (props: Omit<RootStateType, 'byId'>) => {
65-
const [state, setState] = useState({ list: props.list })
64+
const [state, setState] = React.useState({ list: props.list })
6665

6766
component1StateList = state.list
6867

69-
useEffect(() => {
68+
React.useEffect(() => {
7069
setState((prevState) => ({ ...prevState, list: props.list }))
7170
}, [props.list])
7271

test/integration/dynamic-reducers.spec.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
/*eslint-disable react/prop-types*/
22

3-
import * as React from 'react'
4-
import { createContext } from 'react'
5-
import { renderToString } from 'react-dom/server'
3+
import React from 'react'
4+
import ReactDOMServer from 'react-dom/server'
65
import { createStore, combineReducers } from 'redux'
76
import { connect, Provider, ReactReduxContext } from '../../src/index'
87
import * as rtl from '@testing-library/react'
@@ -30,7 +29,9 @@ describe('React', () => {
3029
because it's the popular approach, this test targets nr 3.
3130
*/
3231
describe('dynamic reducers', () => {
33-
const InjectReducersContext = createContext<((r: any) => void) | null>(null)
32+
const InjectReducersContext = React.createContext<
33+
((r: any) => void) | null
34+
>(null)
3435

3536
type Reducer = (s: any) => any
3637

@@ -184,7 +185,7 @@ describe('React', () => {
184185
// @ts-ignore
185186
console.error.mockImplementation(() => {})
186187

187-
const markup = renderToString(
188+
const markup = ReactDOMServer.renderToString(
188189
<Provider store={store}>
189190
<InjectReducersContext.Provider value={injectReducers}>
190191
<InitialGreeting />

test/tsconfig.test.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"compilerOptions": {
3+
"allowSyntheticDefaultImports": true,
34
"esModuleInterop": true,
45
"module": "esnext",
56
"moduleResolution": "node",

test/typetests/react-redux-types.typetest.tsx

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
/* eslint-disable @typescript-eslint/no-unused-vars, no-inner-declarations */
2-
import {
3-
createElement,
4-
Component,
5-
ComponentType,
6-
ReactElement,
7-
ReactNode,
8-
} from 'react'
9-
import * as React from 'react'
10-
import { render } from 'react-dom'
2+
import { Component, ReactElement } from 'react'
3+
import React from 'react'
4+
import ReactDOM from 'react-dom'
115
import {
126
configureStore,
137
createSlice,
@@ -97,15 +91,15 @@ connect<ICounterStateProps, ICounterDispatchProps, {}, {}, CounterState>(
9791
)(Counter)
9892

9993
class App extends Component<any, any> {
100-
render(): ReactNode {
94+
render(): React.ReactNode {
10195
// ...
10296
return null
10397
}
10498
}
10599

106100
const targetEl = document.getElementById('root')
107101

108-
render(
102+
ReactDOM.render(
109103
<Provider store={store}>
110104
<App />
111105
</Provider>,
@@ -135,7 +129,7 @@ type AddTodoAction = ReturnType<typeof addTodo>
135129
declare var todoActionCreators: { [type: string]: (...args: any[]) => any }
136130
declare var counterActionCreators: { [type: string]: (...args: any[]) => any }
137131

138-
render(
132+
ReactDOM.render(
139133
<Provider store={store}>
140134
<MyRootComponent />
141135
</Provider>,
@@ -252,7 +246,7 @@ class TestComponent extends Component<TestProp, TestState> {}
252246
const WrappedTestComponent = connect()(TestComponent)
253247

254248
// return value of the connect()(TestComponent) is of the type TestComponent
255-
let ATestComponent: ComponentType<TestProp>
249+
let ATestComponent: React.ComponentType<TestProp>
256250
ATestComponent = TestComponent
257251
ATestComponent = WrappedTestComponent
258252

@@ -277,8 +271,11 @@ function HelloMessage(props: HelloMessageProps) {
277271
return <div>Hello {props.name}</div>
278272
}
279273
let ConnectedHelloMessage = connect()(HelloMessage)
280-
render(<HelloMessage name="Sebastian" />, document.getElementById('content'))
281-
render(
274+
ReactDOM.render(
275+
<HelloMessage name="Sebastian" />,
276+
document.getElementById('content')
277+
)
278+
ReactDOM.render(
282279
<ConnectedHelloMessage name="Sebastian" />,
283280
document.getElementById('content')
284281
)
@@ -327,7 +324,7 @@ namespace TestTOwnPropsInference {
327324
state: string
328325
}
329326

330-
class OwnPropsComponent extends Component<OwnProps & StateProps, {}> {
327+
class OwnPropsComponent extends React.Component<OwnProps & StateProps, {}> {
331328
render() {
332329
return <div />
333330
}
@@ -355,28 +352,28 @@ namespace TestTOwnPropsInference {
355352
)(OwnPropsComponent)
356353

357354
// @ts-expect-error
358-
createElement(ConnectedWithoutOwnProps, { anything: 'goes!' })
355+
React.createElement(ConnectedWithoutOwnProps, { anything: 'goes!' })
359356

360357
// This compiles, as expected.
361-
createElement(ConnectedWithOwnProps, { own: 'string' })
358+
React.createElement(ConnectedWithOwnProps, { own: 'string' })
362359

363360
// This should not compile, which is good.
364361
// @ts-expect-error
365-
createElement(ConnectedWithOwnProps, { missingOwn: true })
362+
React.createElement(ConnectedWithOwnProps, { missingOwn: true })
366363

367364
// This compiles, as expected.
368-
createElement(ConnectedWithTypeHint, { own: 'string' })
365+
React.createElement(ConnectedWithTypeHint, { own: 'string' })
369366

370367
// This should not compile, which is good.
371368
// @ts-expect-error
372-
createElement(ConnectedWithTypeHint, { missingOwn: true })
369+
React.createElement(ConnectedWithTypeHint, { missingOwn: true })
373370

374371
interface AllProps {
375372
own: string
376373
state: string
377374
}
378375

379-
class AllPropsComponent extends Component<AllProps & DispatchProp> {
376+
class AllPropsComponent extends React.Component<AllProps & DispatchProp> {
380377
render() {
381378
return <div />
382379
}

0 commit comments

Comments
 (0)