Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes service accounts support #50

Closed
wants to merge 8 commits into from

Conversation

sercand
Copy link

@sercand sercand commented Apr 9, 2016

Localkube does not create service accounts at the beginning which causes problems when using kubernetes api with InClusterConfig. This pull request creates a PEM certificate at start and uses it as service account certificate.

@sercand sercand changed the title Kubernetes service accounts support is added Kubernetes service accounts support [WIP] Apr 9, 2016
@sercand sercand changed the title Kubernetes service accounts support [WIP] Kubernetes service accounts support Apr 9, 2016
@ethernetdan
Copy link
Member

Hey @sercand - thanks for the PR!

@mfburnett and I are working on a process around external contributions with the goal of all changes going through the same standards (with exceptions for hotfixes and non-code changes). Hopefully this will get up within the next week.

@luxas
Copy link

luxas commented Apr 20, 2016

We need this for core Kubernetes localkube

@sercand
Copy link
Author

sercand commented Apr 28, 2016

@ethernetdan any update on this

@ethernetdan
Copy link
Member

ethernetdan commented Apr 28, 2016

@sercand could you rebase and group the standard library imports? Otherwise LGTM

In order to ensure the chain of title for the contribution back to Kubernetes core, I'll need you to sign a Redspread CLA. Is your github email the best place to reach you?

@sercand
Copy link
Author

sercand commented Apr 28, 2016

GitHub email is ok.

Sercan Değirmenci

2016-04-28 13:37 GMT+03:00 Dan Gillespie notifications@github.com:

@sercand https://github.com/sercand could you rebase and group the
standard library imports? Otherwise LGTM

In order to ensure the chain of title for the contribution back to
Kubernetes core, I'll need you to sign Redspread CLA. Is your github email
the best place to reach you?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#50 (comment)

@ethernetdan
Copy link
Member

Just sent

@luxas
Copy link

luxas commented May 5, 2016

Should we retarget this one for minikube now?

@ethernetdan
Copy link
Member

@luxas I think that's a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants