Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream to consumer while chunk is downloading #12711

Open
abhijat opened this issue Aug 10, 2023 · 2 comments
Open

Stream to consumer while chunk is downloading #12711

abhijat opened this issue Aug 10, 2023 · 2 comments
Assignees
Labels
area/cloud-storage Shadow indexing subsystem kind/enhance New feature or request

Comments

@abhijat
Copy link
Contributor

abhijat commented Aug 10, 2023

When a chunk is downloading, we block the consumer until the download is finished. Once done, we read from disk and serve the fetch request. Instead of this, we should be able to serve the fetch request while downloading, from the same stream.

JIRA Link: CORE-1399

@abhijat abhijat added the kind/enhance New feature or request label Aug 10, 2023
@abhijat abhijat self-assigned this Aug 10, 2023
@abhijat abhijat added the area/cloud-storage Shadow indexing subsystem label Aug 10, 2023
@abhijat
Copy link
Contributor Author

abhijat commented Oct 3, 2023

This might need some rework based on recent discussions. The current approach in #12837 relies on stream while downloading. Another possible approach suggested by the team:

  • stream the initial request
  • once the current fetch completes (due to overbudget etc) download the remaining data to disk, so that when the consumer returns it is served disk based content

@toddfarmer
Copy link

Per discussion with @piyushredpanda , this is being set to Backlog. There's no associated Aha feature that might inform stakeholders - @mattschumpert , please review if any coordination is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-storage Shadow indexing subsystem kind/enhance New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants