Skip to content

Commit bbc62e3

Browse files
kbatuigasmicheleRP
andauthored
Apply suggestions from code review
Co-authored-by: Michele Cyran <michele@redpanda.com>
1 parent 2de039b commit bbc62e3

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

modules/manage/pages/iceberg/iceberg-topics-aws-glue.adoc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ endif::[]
4242
AWS Glue does not support partitioning on nested fields. If Redpanda detects that
4343
the default partitioning `(hour(redpanda.timestamp))` based on the record metadata is in use, it will instead apply an empty partition spec `()`, which means the table will not be partitioned.
4444

45-
If you want to use partitioning, you must implement custom partitioning using your own partition columns (columns that are not nested).
45+
To use partitioning, you must implement custom partitioning using your own partition columns (that is, columns that are not nested).
4646

4747
[NOTE]
4848
====
@@ -55,19 +55,19 @@ The AWS Glue catalog integration does not support automatic deletion of Iceberg
5555

5656
* Set the cluster property config_ref:iceberg_delete,true,properties/cluster-properties[`iceberg_delete`] to `false` when you configure the catalog integration.
5757
ifndef::env-cloud[]
58-
* Override the cluster-wide `iceberg_delete` configuration and set the topic property xref:reference:properties/topic-properties.adoc#redpanda-iceberg-delete[`redpanda.iceberg.delete`] to `false` for the topic you want to delete.
58+
* Override the cluster property `iceberg_delete` by setting the topic property xref:reference:properties/topic-properties.adoc#redpanda-iceberg-delete[`redpanda.iceberg.delete`] to `false` for the topic you want to delete.
5959
endif::[]
6060
ifdef::env-cloud[]
61-
* Override the cluster-wide `iceberg_delete` configuration and set the topic property `redpanda.iceberg.delete` to `false` for the topic you want to delete.
61+
* Override the cluster property `iceberg_delete` by setting the topic property `redpanda.iceberg.delete` to `false` for the topic you want to delete.
6262
endif::[]
6363

64-
When `iceberg_delete` or the topic override `redpanda.iceberg.delete` is set to `false`, you can delete the Redpanda topic, and then delete the table in AWS Glue and the Iceberg data and metadata files in the S3 bucket. If your intent is to recreate the topic after deleting it, you are required to delete the table data entirely before recreating the topic.
64+
When `iceberg_delete` or the topic override `redpanda.iceberg.delete` is set to `false`, you can delete the Redpanda topic, and then delete the table in AWS Glue and the Iceberg data and metadata files in the S3 bucket. If you plan to re-create the topic after deleting it, you must delete the table data entirely before re-creating the topic.
6565

6666
== Authorize access to AWS Glue
6767

6868
You must allow Redpanda access to AWS Glue services in your AWS account. You can use the same access credentials that you configured for S3 (IAM role, access keys, and KMS key), as long as you have also added read and write access to AWS Glue Data Catalog.
6969

70-
For example, you could create a separate IAM policy that manages access to AWS Glue, and attach it to the IAM role that Redpanda also uses to access S3. It is recommended to add all AWS Glue API actions in the policy (`"glue:*"`) on the following resources:
70+
For example, you could create a separate IAM policy that manages access to AWS Glue and attach it to the IAM role that Redpanda also uses to access S3. Add all AWS Glue API actions in the policy (`"glue:*"`) on the following resources:
7171

7272
- Root catalog (`catalog`)
7373
- All databases (`database/*`)

modules/manage/partials/iceberg/use-iceberg-catalogs.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ The following shows the current status of Iceberg catalog integrations. Check th
6666
|===
6767
endif::[]
6868

69-
Other REST catalogs such as Apache Polaris, Dremio Nessie (to be link:https://www.dremio.com/newsroom/polaris-catalog-to-be-merged-with-nessie-now-available-on-github/[merged with Polaris]), and the Apache reference implementation have been tested but are not regularly verified. For more information, contact https://support.redpanda.com/hc/en-us/requests/new[Redpanda Support^].
69+
Other REST catalogs, such as Apache Polaris, Dremio Nessie (to be link:https://www.dremio.com/newsroom/polaris-catalog-to-be-merged-with-nessie-now-available-on-github/[merged with Polaris]), and the Apache reference implementation, have been tested but are not regularly verified. For more information, contact https://support.redpanda.com/hc/en-us/requests/new[Redpanda Support^].
7070

7171
=== Set cluster properties
7272

0 commit comments

Comments
 (0)