Skip to content

Commit 3435e78

Browse files
authored
Merge pull request kubernetes#5946 from ddgenome/no-cluster-namespace
Do not add namespace to cluster-scoped resources
2 parents ded95c7 + f4585f9 commit 3435e78

File tree

7 files changed

+405
-433
lines changed

7 files changed

+405
-433
lines changed

deploy/static/provider/aws/deploy-tls-termination.yaml

Lines changed: 67 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ metadata:
5555
app.kubernetes.io/version: 0.34.1
5656
app.kubernetes.io/managed-by: Helm
5757
name: ingress-nginx
58-
namespace: ingress-nginx
5958
rules:
6059
- apiGroups:
6160
- ''
@@ -126,7 +125,6 @@ metadata:
126125
app.kubernetes.io/version: 0.34.1
127126
app.kubernetes.io/managed-by: Helm
128127
name: ingress-nginx
129-
namespace: ingress-nginx
130128
roleRef:
131129
apiGroup: rbac.authorization.k8s.io
132130
kind: ClusterRole
@@ -440,7 +438,6 @@ metadata:
440438
app.kubernetes.io/managed-by: Helm
441439
app.kubernetes.io/component: admission-webhook
442440
name: ingress-nginx-admission
443-
namespace: ingress-nginx
444441
webhooks:
445442
- name: validate.nginx.ingress.kubernetes.io
446443
rules:
@@ -465,6 +462,23 @@ webhooks:
465462
name: ingress-nginx-controller-admission
466463
path: /extensions/v1beta1/ingresses
467464
---
465+
# Source: ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml
466+
apiVersion: v1
467+
kind: ServiceAccount
468+
metadata:
469+
name: ingress-nginx-admission
470+
annotations:
471+
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
472+
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
473+
labels:
474+
helm.sh/chart: ingress-nginx-2.11.1
475+
app.kubernetes.io/name: ingress-nginx
476+
app.kubernetes.io/instance: ingress-nginx
477+
app.kubernetes.io/version: 0.34.1
478+
app.kubernetes.io/managed-by: Helm
479+
app.kubernetes.io/component: admission-webhook
480+
namespace: ingress-nginx
481+
---
468482
# Source: ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml
469483
apiVersion: rbac.authorization.k8s.io/v1
470484
kind: ClusterRole
@@ -480,7 +494,6 @@ metadata:
480494
app.kubernetes.io/version: 0.34.1
481495
app.kubernetes.io/managed-by: Helm
482496
app.kubernetes.io/component: admission-webhook
483-
namespace: ingress-nginx
484497
rules:
485498
- apiGroups:
486499
- admissionregistration.k8s.io
@@ -505,7 +518,6 @@ metadata:
505518
app.kubernetes.io/version: 0.34.1
506519
app.kubernetes.io/managed-by: Helm
507520
app.kubernetes.io/component: admission-webhook
508-
namespace: ingress-nginx
509521
roleRef:
510522
apiGroup: rbac.authorization.k8s.io
511523
kind: ClusterRole
@@ -515,6 +527,56 @@ subjects:
515527
name: ingress-nginx-admission
516528
namespace: ingress-nginx
517529
---
530+
# Source: ingress-nginx/templates/admission-webhooks/job-patch/role.yaml
531+
apiVersion: rbac.authorization.k8s.io/v1
532+
kind: Role
533+
metadata:
534+
name: ingress-nginx-admission
535+
annotations:
536+
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
537+
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
538+
labels:
539+
helm.sh/chart: ingress-nginx-2.11.1
540+
app.kubernetes.io/name: ingress-nginx
541+
app.kubernetes.io/instance: ingress-nginx
542+
app.kubernetes.io/version: 0.34.1
543+
app.kubernetes.io/managed-by: Helm
544+
app.kubernetes.io/component: admission-webhook
545+
namespace: ingress-nginx
546+
rules:
547+
- apiGroups:
548+
- ''
549+
resources:
550+
- secrets
551+
verbs:
552+
- get
553+
- create
554+
---
555+
# Source: ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml
556+
apiVersion: rbac.authorization.k8s.io/v1
557+
kind: RoleBinding
558+
metadata:
559+
name: ingress-nginx-admission
560+
annotations:
561+
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
562+
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
563+
labels:
564+
helm.sh/chart: ingress-nginx-2.11.1
565+
app.kubernetes.io/name: ingress-nginx
566+
app.kubernetes.io/instance: ingress-nginx
567+
app.kubernetes.io/version: 0.34.1
568+
app.kubernetes.io/managed-by: Helm
569+
app.kubernetes.io/component: admission-webhook
570+
namespace: ingress-nginx
571+
roleRef:
572+
apiGroup: rbac.authorization.k8s.io
573+
kind: Role
574+
name: ingress-nginx-admission
575+
subjects:
576+
- kind: ServiceAccount
577+
name: ingress-nginx-admission
578+
namespace: ingress-nginx
579+
---
518580
# Source: ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml
519581
apiVersion: batch/v1
520582
kind: Job
@@ -602,70 +664,3 @@ spec:
602664
securityContext:
603665
runAsNonRoot: true
604666
runAsUser: 2000
605-
---
606-
# Source: ingress-nginx/templates/admission-webhooks/job-patch/role.yaml
607-
apiVersion: rbac.authorization.k8s.io/v1
608-
kind: Role
609-
metadata:
610-
name: ingress-nginx-admission
611-
annotations:
612-
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
613-
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
614-
labels:
615-
helm.sh/chart: ingress-nginx-2.11.1
616-
app.kubernetes.io/name: ingress-nginx
617-
app.kubernetes.io/instance: ingress-nginx
618-
app.kubernetes.io/version: 0.34.1
619-
app.kubernetes.io/managed-by: Helm
620-
app.kubernetes.io/component: admission-webhook
621-
namespace: ingress-nginx
622-
rules:
623-
- apiGroups:
624-
- ''
625-
resources:
626-
- secrets
627-
verbs:
628-
- get
629-
- create
630-
---
631-
# Source: ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml
632-
apiVersion: rbac.authorization.k8s.io/v1
633-
kind: RoleBinding
634-
metadata:
635-
name: ingress-nginx-admission
636-
annotations:
637-
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
638-
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
639-
labels:
640-
helm.sh/chart: ingress-nginx-2.11.1
641-
app.kubernetes.io/name: ingress-nginx
642-
app.kubernetes.io/instance: ingress-nginx
643-
app.kubernetes.io/version: 0.34.1
644-
app.kubernetes.io/managed-by: Helm
645-
app.kubernetes.io/component: admission-webhook
646-
namespace: ingress-nginx
647-
roleRef:
648-
apiGroup: rbac.authorization.k8s.io
649-
kind: Role
650-
name: ingress-nginx-admission
651-
subjects:
652-
- kind: ServiceAccount
653-
name: ingress-nginx-admission
654-
namespace: ingress-nginx
655-
---
656-
# Source: ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml
657-
apiVersion: v1
658-
kind: ServiceAccount
659-
metadata:
660-
name: ingress-nginx-admission
661-
annotations:
662-
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
663-
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
664-
labels:
665-
helm.sh/chart: ingress-nginx-2.11.1
666-
app.kubernetes.io/name: ingress-nginx
667-
app.kubernetes.io/instance: ingress-nginx
668-
app.kubernetes.io/version: 0.34.1
669-
app.kubernetes.io/managed-by: Helm
670-
app.kubernetes.io/component: admission-webhook
671-
namespace: ingress-nginx

deploy/static/provider/aws/deploy.yaml

Lines changed: 67 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ metadata:
4848
app.kubernetes.io/version: 0.34.1
4949
app.kubernetes.io/managed-by: Helm
5050
name: ingress-nginx
51-
namespace: ingress-nginx
5251
rules:
5352
- apiGroups:
5453
- ''
@@ -119,7 +118,6 @@ metadata:
119118
app.kubernetes.io/version: 0.34.1
120119
app.kubernetes.io/managed-by: Helm
121120
name: ingress-nginx
122-
namespace: ingress-nginx
123121
roleRef:
124122
apiGroup: rbac.authorization.k8s.io
125123
kind: ClusterRole
@@ -428,7 +426,6 @@ metadata:
428426
app.kubernetes.io/managed-by: Helm
429427
app.kubernetes.io/component: admission-webhook
430428
name: ingress-nginx-admission
431-
namespace: ingress-nginx
432429
webhooks:
433430
- name: validate.nginx.ingress.kubernetes.io
434431
rules:
@@ -453,6 +450,23 @@ webhooks:
453450
name: ingress-nginx-controller-admission
454451
path: /extensions/v1beta1/ingresses
455452
---
453+
# Source: ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml
454+
apiVersion: v1
455+
kind: ServiceAccount
456+
metadata:
457+
name: ingress-nginx-admission
458+
annotations:
459+
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
460+
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
461+
labels:
462+
helm.sh/chart: ingress-nginx-2.11.1
463+
app.kubernetes.io/name: ingress-nginx
464+
app.kubernetes.io/instance: ingress-nginx
465+
app.kubernetes.io/version: 0.34.1
466+
app.kubernetes.io/managed-by: Helm
467+
app.kubernetes.io/component: admission-webhook
468+
namespace: ingress-nginx
469+
---
456470
# Source: ingress-nginx/templates/admission-webhooks/job-patch/clusterrole.yaml
457471
apiVersion: rbac.authorization.k8s.io/v1
458472
kind: ClusterRole
@@ -468,7 +482,6 @@ metadata:
468482
app.kubernetes.io/version: 0.34.1
469483
app.kubernetes.io/managed-by: Helm
470484
app.kubernetes.io/component: admission-webhook
471-
namespace: ingress-nginx
472485
rules:
473486
- apiGroups:
474487
- admissionregistration.k8s.io
@@ -493,7 +506,6 @@ metadata:
493506
app.kubernetes.io/version: 0.34.1
494507
app.kubernetes.io/managed-by: Helm
495508
app.kubernetes.io/component: admission-webhook
496-
namespace: ingress-nginx
497509
roleRef:
498510
apiGroup: rbac.authorization.k8s.io
499511
kind: ClusterRole
@@ -503,6 +515,56 @@ subjects:
503515
name: ingress-nginx-admission
504516
namespace: ingress-nginx
505517
---
518+
# Source: ingress-nginx/templates/admission-webhooks/job-patch/role.yaml
519+
apiVersion: rbac.authorization.k8s.io/v1
520+
kind: Role
521+
metadata:
522+
name: ingress-nginx-admission
523+
annotations:
524+
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
525+
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
526+
labels:
527+
helm.sh/chart: ingress-nginx-2.11.1
528+
app.kubernetes.io/name: ingress-nginx
529+
app.kubernetes.io/instance: ingress-nginx
530+
app.kubernetes.io/version: 0.34.1
531+
app.kubernetes.io/managed-by: Helm
532+
app.kubernetes.io/component: admission-webhook
533+
namespace: ingress-nginx
534+
rules:
535+
- apiGroups:
536+
- ''
537+
resources:
538+
- secrets
539+
verbs:
540+
- get
541+
- create
542+
---
543+
# Source: ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml
544+
apiVersion: rbac.authorization.k8s.io/v1
545+
kind: RoleBinding
546+
metadata:
547+
name: ingress-nginx-admission
548+
annotations:
549+
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
550+
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
551+
labels:
552+
helm.sh/chart: ingress-nginx-2.11.1
553+
app.kubernetes.io/name: ingress-nginx
554+
app.kubernetes.io/instance: ingress-nginx
555+
app.kubernetes.io/version: 0.34.1
556+
app.kubernetes.io/managed-by: Helm
557+
app.kubernetes.io/component: admission-webhook
558+
namespace: ingress-nginx
559+
roleRef:
560+
apiGroup: rbac.authorization.k8s.io
561+
kind: Role
562+
name: ingress-nginx-admission
563+
subjects:
564+
- kind: ServiceAccount
565+
name: ingress-nginx-admission
566+
namespace: ingress-nginx
567+
---
506568
# Source: ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml
507569
apiVersion: batch/v1
508570
kind: Job
@@ -590,70 +652,3 @@ spec:
590652
securityContext:
591653
runAsNonRoot: true
592654
runAsUser: 2000
593-
---
594-
# Source: ingress-nginx/templates/admission-webhooks/job-patch/role.yaml
595-
apiVersion: rbac.authorization.k8s.io/v1
596-
kind: Role
597-
metadata:
598-
name: ingress-nginx-admission
599-
annotations:
600-
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
601-
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
602-
labels:
603-
helm.sh/chart: ingress-nginx-2.11.1
604-
app.kubernetes.io/name: ingress-nginx
605-
app.kubernetes.io/instance: ingress-nginx
606-
app.kubernetes.io/version: 0.34.1
607-
app.kubernetes.io/managed-by: Helm
608-
app.kubernetes.io/component: admission-webhook
609-
namespace: ingress-nginx
610-
rules:
611-
- apiGroups:
612-
- ''
613-
resources:
614-
- secrets
615-
verbs:
616-
- get
617-
- create
618-
---
619-
# Source: ingress-nginx/templates/admission-webhooks/job-patch/rolebinding.yaml
620-
apiVersion: rbac.authorization.k8s.io/v1
621-
kind: RoleBinding
622-
metadata:
623-
name: ingress-nginx-admission
624-
annotations:
625-
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
626-
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
627-
labels:
628-
helm.sh/chart: ingress-nginx-2.11.1
629-
app.kubernetes.io/name: ingress-nginx
630-
app.kubernetes.io/instance: ingress-nginx
631-
app.kubernetes.io/version: 0.34.1
632-
app.kubernetes.io/managed-by: Helm
633-
app.kubernetes.io/component: admission-webhook
634-
namespace: ingress-nginx
635-
roleRef:
636-
apiGroup: rbac.authorization.k8s.io
637-
kind: Role
638-
name: ingress-nginx-admission
639-
subjects:
640-
- kind: ServiceAccount
641-
name: ingress-nginx-admission
642-
namespace: ingress-nginx
643-
---
644-
# Source: ingress-nginx/templates/admission-webhooks/job-patch/serviceaccount.yaml
645-
apiVersion: v1
646-
kind: ServiceAccount
647-
metadata:
648-
name: ingress-nginx-admission
649-
annotations:
650-
helm.sh/hook: pre-install,pre-upgrade,post-install,post-upgrade
651-
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
652-
labels:
653-
helm.sh/chart: ingress-nginx-2.11.1
654-
app.kubernetes.io/name: ingress-nginx
655-
app.kubernetes.io/instance: ingress-nginx
656-
app.kubernetes.io/version: 0.34.1
657-
app.kubernetes.io/managed-by: Helm
658-
app.kubernetes.io/component: admission-webhook
659-
namespace: ingress-nginx

0 commit comments

Comments
 (0)