adds support for int8 and uint8 dtypes in vectorizers #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-cechmanek
requested review from
abrookins,
tylerhutcherson and
rbs333
rbs333
reviewed
Feb 12, 2025
tylerhutcherson
previously approved these changes
Feb 13, 2025
| @@ -19,4 +19,5 @@ vectorizer: | |||
| model: sentence-transformers/all-mpnet-base-v2 | |||
| routing_config: | |||
| max_k: 2 | |||
| aggregation_method: avg | |||
There was a problem hiding this comment.
@rbs333 this is related to what I DM'd you about regarding the deprecated distance_threshold arg
abrookins
reviewed
Feb 13, 2025
| @@ -316,6 +320,7 @@ async def aembed_many( | |||
| ] | |||
| return embeddings | |||
|
|
|||
| @deprecated_argument("dtype") | |||
There was a problem hiding this comment.
😂 This looks like it was fun
justin-cechmanek
dismissed stale reviews from abrookins and tylerhutcherson
via
eadb932
tylerhutcherson
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes support for two integer dtypes, and also markes the 'dtype' kwarg in embedding methods as deprecated.