Modularize testing suite #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
requested review from
abrookins,
justin-cechmanek,
bsbodden and
rbs333
tylerhutcherson
changed the title
abrookins
reviewed
Feb 12, 2025
| @@ -29,17 +30,25 @@ def check_mypy(): | |||
|
|
|||
|
|
|||
| def test(): | |||
| subprocess.run(["python", "-m", "pytest", "-n", "auto", "--log-level=CRITICAL"], check=True) | |||
| test_cmd = ["python", "-m", "pytest", "-n", "auto", "--log-level=CRITICAL"] | |||
There was a problem hiding this comment.
This is nice because you can pass -n 0 to disable xdist and it'll override the earlier -n arg.
abrookins
previously approved these changes
Feb 12, 2025
abrookins
previously approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few improvements to our test suite to make it more modular.
poetry run test tests/unit/test_fields.pyOR
This removes the need to set those ugly
SKIP_VECTORIZER=trueflags.And run without the API dependencies:
make testOR