Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode search results at field level #3309

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Decode search results at field level #3309

merged 7 commits into from
Jul 10, 2024

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Jul 9, 2024

Fixes: #2772, #2275

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@uglide uglide force-pushed the allow_custom_decoding_for_search_query_fields branch from fe30d4f to 1403c95 Compare July 9, 2024 16:40
@uglide uglide mentioned this pull request Jul 9, 2024
Open
@uglide uglide force-pushed the allow_custom_decoding_for_search_query_fields branch from 1403c95 to 7ca2f29 Compare July 9, 2024 16:46
@uglide uglide requested review from gerzse and tylerhutcherson July 9, 2024 17:13
bsbodden
bsbodden reviewed Jul 9, 2024
View reviewed changes
Copy link

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

tylerhutcherson
tylerhutcherson approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team -- looks great

gerzse
gerzse reviewed Jul 10, 2024
View reviewed changes
redis/commands/search/commands.py Show resolved Hide resolved
redis/commands/search/commands.py Show resolved Hide resolved
redis/commands/search/result.py Show resolved Hide resolved
tests/test_asyncio/test_search.py Show resolved Hide resolved
tests/test_search.py Show resolved Hide resolved
tests/test_search.py Show resolved Hide resolved
@gerzse gerzse added the bug Bug label Jul 10, 2024
@gerzse gerzse merged commit 1bb8eab into redis:master Jul 10, 2024
45 checks passed
gerzse pushed a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
@uglide @gerzse
Decode search results at field level (redis#3309)
8c79060 
Make it possible to configure at field level how search
results are decoded.

Fixes: redis#2772, redis#2275
gerzse pushed a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
@uglide @gerzse
Decode search results at field level (redis#3309)
62fc873 
Make it possible to configure at field level how search
results are decoded.

Fixes: redis#2772, redis#2275
gerzse pushed a commit that referenced this pull request Jul 11, 2024
@uglide @gerzse
Decode search results at field level (#3309)
6a2a636 
Make it possible to configure at field level how search
results are decoded.

Fixes: #2772, #2275
@gerzse gerzse mentioned this pull request Jul 11, 2024
Closed
6 tasks
agnesnatasya pushed a commit to agnesnatasya/redis-py that referenced this pull request Jul 20, 2024
@uglide @agnesnatasya
Decode search results at field level (redis#3309)
d02d78a 
Make it possible to configure at field level how search
results are decoded.

Fixes: redis#2772, redis#2275
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@uglide @vladvildanov
Decode search results at field level (#3309)
68f9450 
Make it possible to configure at field level how search
results are decoded.

Fixes: #2772, #2275
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@uglide @vladvildanov
Decode search results at field level (#3309)
f6351ee 
Make it possible to configure at field level how search
results are decoded.

Fixes: #2772, #2275
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@uglide @vladvildanov
Decode search results at field level (#3309)
2717a0e 
Make it possible to configure at field level how search
results are decoded.

Fixes: #2772, #2275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsbodden bsbodden bsbodden left review comments

@tylerhutcherson tylerhutcherson tylerhutcherson approved these changes

@gerzse gerzse gerzse approved these changes

Assignees
No one assigned
Labels
bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bytes Vectors from r.hget vs Bytes string returned from r.ft().search(query="*")
4 participants
@uglide @bsbodden @gerzse @tylerhutcherson